Remove data dependency from from core module in `consensus/types
#8694
+129
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macladson
added
work-in-progress
pawanjay176
reviewed
Jan 22, 2026
Member
pawanjay176
left a comment
pawanjay176
left a comment
There was a problem hiding this comment.
Looks good. Just a few nits about docs and a suggestion for a test
|
|
||
| #[test] | ||
| fn max_data_columns_by_root_request_matches_simplified() { | ||
| for n in [0, 1, 2, 8, 16, 32, 64, 128, 256, 512, 1024] { |
Member
There was a problem hiding this comment.
maybe we can make sure it also works for default_max_request_blocks too since that's what's actually gets used?
Member
Author
There was a problem hiding this comment.
Isn't the value that actually gets used 128?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#8652
Proposed Changes
Implements "simplified" versions of
max_blobs_by_root_requestandmax_data_columns_by_root_requestwhich do not depend on type information from thedatamodule. I've also added tests which test the original implementation against the simplified one to ensure they don't deviate.Also moves
all_data_column_sidecar_subnetsfrom a method onChainSpecto a function which just takesChainSpecas an argument.Additional Info
This marks the final module blocking the
corefeature set (other thantest_utils). I will add afullfeature in a future PR which will allow compilation ofconsensus/typeswith just thecoreandforkmodules.