Skip to content

Fix issue 374 #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025
+4 −16
Merged

Fix issue 374 #375

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
763b75a
use correct env vars
antondlr May 6, 2025
482aea1
multiarch manifest is pushed by `docker` workflow
antondlr May 6, 2025
5a994cb
use variable link
antondlr May 6, 2025
fcb0a1f
remove unused and faulty `IMAGE_NAME` var
antondlr May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@ on:

env:
REPO_NAME: ${{ github.repository_owner }}/siren
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
IMAGE_NAME: ${{ secrets.DOCKER_USERNAME }}/siren
DOCKER_PASSWORD: ${{ secrets.DH_KEY }}
DOCKER_USERNAME: ${{ secrets.DH_ORG }}

jobs:
extract-version:
Expand Down Expand Up @@ -62,20 +61,9 @@ jobs:
## Release Checklist (DELETE ME)

- [ ] Merge `unstable` -> `stable`.
- [ ] Ensure docker images are published to `sigp` namespace (instructions below)
- [ ] Ensure docker images are published to `sigp` namespace (happens with succesful docker workflow)
- [ ] Prepare Discord post.

Someone with appropriate access rights should run these commands:
0. sanity check: did the `docker` workflow complete correctly, are the images published under the `sigmaprime` namespace?
see: https://hub.docker.com/r/${{ env.DOCKER_USERNAME }}/siren/tags?name=${{ env.VERSION }} and https://hub.docker.com/r/${{ env.DOCKER_USERNAME }}/siren/tags?name=latest
1. publish `latest`:
`docker manifest create sigp/siren:latest --amend sigmaprime/siren:latest-amd64 --amend sigmaprime/siren:latest-arm64`
`docker manifest push sigp/siren:latest`
2. publish `${{ env.VERSION }}`:
`docker manifest create sigp/siren:${{ env.VERSION }} --amend sigmaprime/siren:${{ env.VERSION }}-amd64 --amend sigmaprime/siren:${{ env.VERSION }}-arm64`
`docker manifest push sigp/siren:${{ env.VERSION }}`
3. verify: https://hub.docker.com/r/siren/siren/tags?name=${{ env.VERSION }} and https://hub.docker.com/r/sigp/siren/tags?name=latest

## Summary

Add a summary.
Expand All @@ -94,7 +82,7 @@ jobs:
${{ steps.changelog.outputs.CHANGELOG }}

## Docker Hub
https://hub.docker.com/r/sigp/siren/tags?name=${{ env.VERSION }}
https://hub.docker.com/r/${{ env.DOCKER_USERNAME }}/siren/tags?name=${{ env.VERSION }}

ENDBODY
)
Expand Down