Skip to content

input/vcd: make sure number of maximum channels is valid #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aisuneko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

input/vcd: make sure number of maximum channels is valid #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/input/vcd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,11 @@ static int parse_header_var(struct context *inc, char *contents)
if (inc->conv_bits.max_bits < size)
inc->conv_bits.max_bits = size;
next_size = inc->logic_count + inc->analog_count + size;
if (inc->options.maxchannels && next_size > inc->options.maxchannels) {
if (inc->options.maxchannels < 1){
sr_warn("Number of maximum channels must be at least 1");
return SR_ERR_DATA;
}
if (inc->options.maxchannels > 0 && next_size > inc->options.maxchannels) {
sr_warn("Skipping '%s%s', exceeds requested channel count %zu.",
ref, idx ? idx : "", inc->options.maxchannels);
inc->ignored_signals = g_slist_append(inc->ignored_signals,
Expand Down Expand Up @@ -1954,7 +1958,9 @@ static int init(struct sr_input *in, GHashTable *options)

data = g_hash_table_lookup(options, "numchannels");
inc->options.maxchannels = g_variant_get_uint32(data);

if (inc->options.maxchannels < 1){
inc->options.maxchannels = 1;
}
data = g_hash_table_lookup(options, "samplerate_overwrite");
inc->options.samplerate = g_variant_get_uint64(data);
if (inc->options.samplerate != 0) {
Expand Down