Timing pd end edge feature#60
Open
lrademacher wants to merge 2 commits into
Open
Conversation
added 2 commits
February 23, 2021 18:43
Extracted a separate method for timing region handling, so this PD can easily be extended to handle other types of regions. Specifically this aims at supporting different end edge type.
This change creates support for end edges which differ from the start edge. Both the channel and the edge type can be configured for this feature. The additional feature is optional and the change is backwards compatible (tests were not altered).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change creates support for end edges which differ from the start edge.
Both the channel and the edge type can be configured for this feature.
The additional feature is optional and the change is backwards compatible
(tests were not altered).
The related tests are in this sigrok-test PR: sigrokproject/sigrok-test#16