feat(cli): add --payload-media-type to sign (fixes #4300)#4304
Open
arubegonsan wants to merge 1 commit intosigstore:mainfrom
Open
feat(cli): add --payload-media-type to sign (fixes #4300)#4304arubegonsan wants to merge 1 commit intosigstore:mainfrom
--payload-media-type to sign (fixes #4300)#4304arubegonsan wants to merge 1 commit intosigstore:mainfrom
Conversation
This commit introduces a new `--payload-media-type` flag to the `cosign sign` command. When signing with a custom payload using the `--payload` flag, users can now also specify the MIME type of that payload via `--payload-media-type`. This media type is then stored in the `mediaType` field of the signature layer descriptor in the resulting OCI manifest. This allows consumers of the signature to correctly interpret the payload's content type. If `--payload` is not used, this flag is ignored. Signed-off-by: Alberto Gonzalez <albgonz@google.com>
arubegonsan
force-pushed
the
payload-media-type
branch
from
f8d3d14 to
8850f72
Compare
cmurphy
requested changes
Oct 10, 2025
Contributor
cmurphy
left a comment
cmurphy
left a comment
There was a problem hiding this comment.
Could you add a test for this?
|
|
||
| var s icos.Signer | ||
| s = ipayload.NewSigner(sv) | ||
| var staticOpts []static.StaticOption |
Contributor
There was a problem hiding this comment.
It looks like the majority of the changed lines in this PR come from renaming this type. It's creating a lot of noise, and you'll find that it trips up the linter because it creates a "stutter". I don't think it's necessary to rename it because it's clear what it's for based on the package name. Could you undo this rename?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit introduces a new
--payload-media-typeflag to thecosign signcommand.When signing with a custom payload using the
--payloadflag, users can now also specify the MIME type of that payload via--payload-media-type.This media type is then stored in the
mediaTypefield of the signature layer descriptor in the resulting OCI manifest. This allows consumers of the signature to correctly interpret the payload's content type.If
--payloadis not used, this flag is ignored.Release Note
cosign sign --payloadhardcodes layer MIME toapplication/vnd.dev.cosign.simplesigning.v1+json#4300: introduced the--payload-media-typeflag incosign sign.Documentation
Needs documentation change.