Add hashedrekord support to attest-blob and attest#4622
Closed
steiza wants to merge 5 commits intosigstore:mainfrom
Closed
Add hashedrekord support to attest-blob and attest#4622steiza wants to merge 5 commits intosigstore:mainfrom
steiza wants to merge 5 commits intosigstore:mainfrom
Conversation
Signed-off-by: Zach Steindler <steiza@github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4622 +/- ##
==========================================
- Coverage 40.10% 36.08% -4.02%
==========================================
Files 155 220 +65
Lines 10044 12429 +2385
==========================================
+ Hits 4028 4485 +457
- Misses 5530 7250 +1720
- Partials 486 694 +208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
Member
Author
|
After exploring this approach, I don't think this is a good idea. We should instead encourage people not to create large bundles that are 100s of MBs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For #3599, as an alternative to #4490
There are cases where people want to have large attestations (like SBOMs) which introduce a couple of issues:
attest-blobalready has--rekor-entry-type, although previously it only supporteddsseandintoto. This change addshashedrekordsupport, and the resulting bundle has amessageSignatureinstead of a largedsseEnvelope.Of course, you need a way to verify the resulting bundle. With this change you can do so with
verify-blob(instead ofverify-blob-attestation, where the blob you verify is the DSSE PAE.We probably wouldn't land this as-is, due to two issues:
currently the PAE is printed out for convenience, although for large attestations this is not very desirable. We could either have the command save the PAE to disk for you, or we could print out the hash and add hash support to
verify-blob(verify-blob-attestationalready has hash support).this only works when you are using signing config, although Restructuring signing code for shared implementation #4570 / Sign exclusively via sigstore-go #4618 are working on unifying codepaths so that in the future this would also work without signing config.
You can test this with something like:
Release Note
--rekor-entry-type=hashedrekordsupport toattestandattest-blobwhen signing config is usedDocumentation
N/A