Closed
Conversation
Downloading SBOM can be memory-intensive as whole SBOM is read into memory, while it can be streamed. Signed-off-by: Tomas Kopecek <tkopecek@redhat.com>
Author
|
ok, closing MR/issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downloading SBOM can be memory-intensive as whole SBOM is read into memory, while it can be streamed.
Closes #4741
Summary
Downloading large SBOMs requires a lot of memory. Using streaming approach would limit it. For testing improvements just monitor used memory e.g. via
GODEBUG=gctrace=1Otherwise there should be no changes in behaviour, so all current tests should pass.Release Note
NONE
IMPORTANT: This MR is heavily supported by Claude as I'm not a go developer. So, if you're willing to go with this apprach, please a) doublecheck the code changes b) let me know if there is AI-assistance policy which I should acknowledge.