Skip to content

Require bundle output or registry upload #4785

Draft
aaronlew02 wants to merge 2 commits intosigstore:mainfrom
aaronlew02:verification-material
Draft

Require bundle output or registry upload #4785
aaronlew02 wants to merge 2 commits intosigstore:mainfrom
aaronlew02:verification-material

Conversation

@aaronlew02
Copy link
Copy Markdown
Contributor

@aaronlew02 aaronlew02 commented Mar 30, 2026

Depends on #4618

Closes #4534

Summary

This change requires that the user enable OCI registry upload (where applicable) or specify a bundle output path so that all signing events provide material with which the user can verify the signing event.

Release Note

This change applies only to users requesting a new-format bundle.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 9.58231% with 368 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.37%. Comparing base (2ef6022) to head (bcbb29e).
⚠️ Report is 710 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cosign/cli/signcommon/common.go 0.00% 147 Missing ⚠️
cmd/cosign/cli/sign/sign.go 0.00% 73 Missing ⚠️
cmd/cosign/cli/attest/attest.go 0.00% 53 Missing ⚠️
cmd/cosign/cli/sign/sign_blob.go 38.88% 33 Missing and 11 partials ⚠️
cmd/cosign/cli/attest/attest_blob.go 28.20% 22 Missing and 6 partials ⚠️
pkg/cosign/bundle/sign.go 0.00% 5 Missing ⚠️
cmd/cosign/cli/attest.go 0.00% 3 Missing and 1 partial ⚠️
cmd/cosign/cli/attest_blob.go 0.00% 3 Missing and 1 partial ⚠️
cmd/cosign/cli/sign.go 0.00% 3 Missing and 1 partial ⚠️
internal/key/svkeypair.go 0.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4785      +/-   ##
==========================================
- Coverage   40.10%   37.37%   -2.73%     
==========================================
  Files         155      220      +65     
  Lines       10044    12981    +2937     
==========================================
+ Hits         4028     4852     +824     
- Misses       5530     7396    +1866     
- Partials      486      733     +247     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
@aaronlew02 aaronlew02 force-pushed the verification-material branch from 891ebcb to 3ae3808 Compare April 6, 2026 20:02
@aaronlew02 aaronlew02 changed the title Require bundle output when registry upload is disabled Require bundle output or registry upload Apr 7, 2026
@aaronlew02 aaronlew02 force-pushed the verification-material branch from 3ae3808 to a8720a2 Compare April 7, 2026 14:13
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
@aaronlew02 aaronlew02 force-pushed the verification-material branch from a8720a2 to bcbb29e Compare April 7, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require bundle output or registry upload

1 participant