Require bundle output or registry upload #4785
Draft
aaronlew02 wants to merge 2 commits intosigstore:mainfrom
Draft
Require bundle output or registry upload #4785aaronlew02 wants to merge 2 commits intosigstore:mainfrom
aaronlew02 wants to merge 2 commits intosigstore:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4785 +/- ##
==========================================
- Coverage 40.10% 37.37% -2.73%
==========================================
Files 155 220 +65
Lines 10044 12981 +2937
==========================================
+ Hits 4028 4852 +824
- Misses 5530 7396 +1866
- Partials 486 733 +247 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
891ebcb to
3ae3808
Compare
3ae3808 to
a8720a2
Compare
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
a8720a2 to
bcbb29e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #4618
Closes #4534
Summary
This change requires that the user enable OCI registry upload (where applicable) or specify a bundle output path so that all signing events provide material with which the user can verify the signing event.
Release Note
This change applies only to users requesting a new-format bundle.