Use less confusing name for security contexts #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pod-level security context of policy controller's webhook was configured using `webhook.securityContext`, while the container-level security context was using `webhook.podSecurityContext`. The former is debatable, the latter is just plain confusing. This change uses explicit names for both contexts, removing all confusion. BREAKING CHANGE: the values regarding security contexts have been renamed. Signed-off-by: Jorik Jonker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The pod-level security context of policy controller's webhook was configured using
webhook.securityContext, while the container-level security context was usingwebhook.podSecurityContext. The former is debatable, the latter is just plain confusing.This change uses explicit names for both contexts, removing all confusion.
Existing or Associated Issue(s)
n/a, if needed I will create one
Additional Information
This is probably a breaking change, as users overriding security context need to change their values.
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.