Deprecate createcerts #1103
Merged
Deprecate createcerts #1103
+40
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydentherapper
previously approved these changes
Dec 11, 2025
charts/fulcio/templates/NOTES.txt
Outdated
| @@ -0,0 +1,4 @@ | |||
| {{- if (.Values.createcerts).enabled -}} | |||
| **DEPRECATED**: createcerts is deprecated. If using the fileca certificate authority, create the fulcio-secrets secret containing the private signing key, encryption password, and certiticate authority manually. | |||
Contributor
There was a problem hiding this comment.
Should we mention that the secret name should be set in Values.server.secret along with the secret keys (private, cert, and and password, or is that self-explanatory from the chart?
Using createcerts to have the Fulcio chart automatically generate its roots for the fileca certificate authority mode is deprecated. Instead, users should generate their key material out of band. This way, the CTLog chart can share the Fulcio root in its configuration instead of implicitly trusting Fulcio's rootCerts endpoint. Signed-off-by: Colleen Murphy <[email protected]>
cmurphy
force-pushed
the
deprecate-createcerts
branch
from
4a7c448 to
8202e22
Compare
haydentherapper
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using createcerts to have the Fulcio chart automatically generate its roots for the fileca certificate authority mode is deprecated. Instead, users should generate their key material out of band. This way, the CTLog chart can share the Fulcio root in its configuration instead of implicitly trusting Fulcio's rootCerts endpoint.
Relates to sigstore/scaffolding#1833
This is how the installation/upgrade message now appears if createcerts.enabled is not set to false:
Description of the change
Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.