Skip to content

add additional env variables to fulcio chart #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Racer159 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

add additional env variables to fulcio chart #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ad2165
feat(fulcio/add-env): Add additional env variables
Racer159 May 18, 2023
a7b1fd4
fix(helm): make env variable optional
Racer159 May 19, 2023
8b50eed
modify env variable type
Racer159 May 21, 2023
1490b45
improve naming scheme for extrernal credential config
Racer159 May 25, 2023
2e84f2e
Resolve or feedback for env section
Racer159 Jul 24, 2024
a2f7ddf
Adjust json schema
Racer159 Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/fulcio/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: |

type: application

version: 2.5.0
version: 2.6.0
appVersion: 1.6.0

keywords:
Expand Down
4 changes: 3 additions & 1 deletion charts/fulcio/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<!-- This README.md is generated. Please edit README.md.gotmpl -->

![Version: 2.5.0](https://img.shields.io/badge/Version-2.5.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.6.0](https://img.shields.io/badge/AppVersion-1.6.0-informational?style=flat-square)
![Version: 2.6.0](https://img.shields.io/badge/Version-2.6.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.6.0](https://img.shields.io/badge/AppVersion-1.6.0-informational?style=flat-square)

Fulcio is a free code signing Certificate Authority, built to make short-lived certificates available to anyone.

Expand Down Expand Up @@ -115,12 +115,14 @@ helm uninstall [RELEASE_NAME]
| server.affinity | object | `{}` | |
| server.args.aws_hsm_root_ca_path | string | `nil` | |
| server.args.certificateAuthority | string | `"fileca"` | |
| server.args.cloud_credential_config | string | `""` | |
| server.args.ct_log_url | string | `""` | |
| server.args.disable_ct_log | bool | `false` | |
| server.args.gcp_private_ca_parent | string | `"projects/test/locations/us-east1/caPools/test"` | |
| server.args.grpcPort | int | `5554` | |
| server.args.hsm_caroot_id | string | `nil` | |
| server.args.port | int | `5555` | |
| server.env | object | `{}` | |
| server.grpcSvcPort | int | `5554` | |
| server.image.pullPolicy | string | `"IfNotPresent"` | |
| server.image.registry | string | `"gcr.io"` | |
Expand Down
3 changes: 3 additions & 0 deletions charts/fulcio/templates/fulcio-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,6 @@ data:
{{- if (eq .Values.server.args.certificateAuthority "kmsca")}}
chain.pem: {{.Values.server.args.kms_cert_chain | quote }}
{{- end }}
{{- if .Values.server.args.cloud_credential_config }}
cloud_credential_config: {{.Values.server.args.cloud_credential_config | quote }}
{{- end }}
18 changes: 12 additions & 6 deletions charts/fulcio/templates/fulcio-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,20 @@ spec:
{{- range .Values.server.extraArgs }}
- {{ . | quote }}
{{- end }}
{{- if eq .Values.server.args.certificateAuthority "fileca" }}
{{- if or .Values.server.env (eq .Values.server.args.certificateAuthority "fileca") }}
env:
- name: PASSWORD
valueFrom:
secretKeyRef:
name: {{ .Values.server.secret }}
key: password
{{- range $key, $value := .Values.server.env }}
- name: "{{ $key }}"
value: "{{ $value }}"
{{- end }}
{{- if eq .Values.server.args.certificateAuthority "fileca" }}
- name: PASSWORD
valueFrom:
secretKeyRef:
name: {{ .Values.server.secret }}
key: password
{{- end }}
{{- end }}
livenessProbe:
failureThreshold: 3
httpGet:
Expand Down
7 changes: 7 additions & 0 deletions charts/fulcio/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@
"gcp_private_ca_parent": {
"type": "string"
},
"cloud_credential_config": {
"type": "string"
},
"grpcPort": {
"type": "integer"
},
Expand Down Expand Up @@ -466,6 +469,10 @@
},
"type": "object"
},
"env": {
"type": "object",
"properties": {}
},
"serviceAccount": {
"properties": {
"annotations": {
Expand Down
3 changes: 3 additions & 0 deletions charts/fulcio/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,12 @@ server:
# crane digest gcr.io/projectsigstore/fulcio:v1.6.0
# -- v1.6.0
version: sha256:9030be23f59405100bc8d24ce2ca493b9d430639ef49b448541a840b3bfd7771
env: {}
args:
port: 5555
grpcPort: 5554
# valid values: GCP workload identity config json for trusted external cloud providers
cloud_credential_config: ""
# Valid values: googleca, pkcs11ca, aws-hsm-root-ca-path, fileca, kmsca
certificateAuthority: fileca
# kms_resource: gcpkms://....
Expand Down