Leases cleanup add security context - #817
Open
ybelMekk wants to merge 2 commits into
Open
Conversation
* In a cluster with https://kubernetes.io/docs/reference/access-authn-authz/validating-admission-policy/ does not clean up Signed-off-by: Youssef Bel Mekki <38552193+ybelMekk@users.noreply.github.com>
* In a cluster with https://kubernetes.io/docs/reference/access-authn-authz/validating-admission-policy/ does not clean up Signed-off-by: Youssef Bel Mekki <38552193+ybelMekk@users.noreply.github.com>
ybelMekk
force-pushed
the
leases_cleanup_add_secuirty_context
branch
from
August 30, 2024 12:57
feccd4d to
2ae8f65
Compare
ybelMekk
changed the title
cmurphy
reviewed
Jun 3, 2026
| enabled: false | ||
| runAsUser: 1000 | ||
| runAsNonRoot: true | ||
| podSecurityContext: |
Contributor
There was a problem hiding this comment.
It looks like this has been added since you proposed this. Does that address the issue or is the other security context needed as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
securityContxect to cleanup-leases job
run-as-non-root: 'validation error: Running as root is not allowed. Either the field..This also relates to issue listed, leases dont get cleaned up the application fails to start if re-deployed.
Existing or Associated Issue(s)
#217 (comment)
Additional Information
Add podSecurity context and security context to values.yaml and corresponding cleanup-lease job.
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.