Allow specifying resources in fulcio createcerts job #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Arcand <[email protected]>
Signed-off-by: Philippe Arcand <[email protected]>
Signed-off-by: Philippe Arcand <[email protected]>
Signed-off-by: Philippe Arcand <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
|
Hi @philarcand, thanks for the PR. Can you update the values schema please? Thanks |
…rver Signed-off-by: Philippe Arcand <[email protected]>
|
Hi @vipulagarwal , thanks for reviewing. I modified the schema in 48d0a71 |
|
Hi @vipulagarwal , just checking on the status of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds the ability to specify resources to the fulcio createcerts job, and documents resources under server.
Existing or Associated Issue(s)
It is currently impossible to specify resources for the fulcio createcerts job, which is problematic for deployments where ResourceQuota is being used, forcing the use of LimitRange.
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.