Model Card #584
Open
Model Card #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ali6x1000
force-pushed
the
main
branch
4 times, most recently
from
2f72786 to
cd69836
Compare
Model Card This adds support for parsing and signing Model Card metadata from a README.md file. This allows users to bind documentation (e.g., license, author, carbon footprint) to the cryptographic signature. Changes: - Added `--readme` flag to all signing commands in the CLI. - Implemented strict YAML parsing and validation using a new Pydantic schema in `src/model_signing/model_card.py`. - Updated `Payload` to merge validated metadata into the in-toto predicate. - Added `PyYAML` to dependencies. ------------------------- Signed-off-by: Ali Nawaf <[email protected]>
mihaimaruseac
requested changes
Dec 9, 2025
Collaborator
mihaimaruseac
left a comment
mihaimaruseac
left a comment
There was a problem hiding this comment.
While this is pending for discussion, please remove any slop added by the AI. Keep only what is relevant to the PR, remove anything done extra, any comments that harm readability rather than helping it.
Signed-off-by: Ali Nawaf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the ability to cryptographically bind Model Card metadata (parsed from
README.mdYAML front matter) to the model signature. Previously, only model artifacts were signed; this enhancement ensures that critical documentation—such as licensing, authorship, and carbon footprint data—is verified alongside the model weights.Key Changes:
--readmeargument to all signing commands (sigstore,key,certificate,pkcs11), allowing users to specify a Model Card file.Pydanticto ensure metadata conforms to Hugging Face Model Card standards (e.g., enforcing numeric types for metrics likeco2_emitted).Payloadclass to merge validated metadata directly into the in-toto predicate during signature generation.PyYAMLto support front matter parsing.Resolves #583
Signed-off-by: Ali6x1000 [email protected]
Summary
Checklist