Skip to content

Conversation

@0xiso
Copy link
Contributor

@0xiso 0xiso commented Jan 9, 2026

This PR updates the expired TUF test data which was causing test failures.

Changes

  • Regenerated pkg/reconciler/trustroot/testdata/root.json and pkg/reconciler/trustroot/testdata/tufRepo.tar using make generate-testdata.
  • Updated hardcoded base64 encoded test data in pkg/apis/policy/v1alpha1/trustroot_validation_test.go and pkg/tuf/repo_test.go.

Files Modified (Manually)

  • pkg/apis/policy/v1alpha1/trustroot_validation_test.go
  • pkg/tuf/repo_test.go

Commands Run

  • make generate-testdata

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.98%. Comparing base (ea54b96) to head (e09f67f).
⚠️ Report is 44 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1920       +/-   ##
===========================================
- Coverage   42.78%   29.98%   -12.80%     
===========================================
  Files         121      122        +1     
  Lines        8994     7323     -1671     
===========================================
- Hits         3848     2196     -1652     
- Misses       4791     4894      +103     
+ Partials      355      233      -122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xiso 0xiso marked this pull request as ready for review January 9, 2026 20:32
Copy link
Collaborator

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should only need to update two files as done in here https://github.com/sigstore/policy-controller/pull/1496/files

@0xiso 0xiso closed this Jan 12, 2026
@0xiso 0xiso reopened this Jan 12, 2026
@0xiso
Copy link
Contributor Author

0xiso commented Jan 14, 2026

@hectorj2f I followed the example in that PR and updated only the two files, however the tests are failing. Am I missing any additional changes that are required?

@0xiso 0xiso requested a review from hectorj2f January 14, 2026 04:50
@hectorj2f
Copy link
Collaborator

It looks like we must update it now in additional places too https://github.com/sigstore/policy-controller/actions/runs/20930413044/job/60139572158?pr=1920

@0xiso 0xiso force-pushed the fix/update-expired-test-data branch from 3f601da to 9275113 Compare January 16, 2026 18:55
The TUF root.json test data had expired (2026-01-01T11:46:29Z),
causing test failures. Regenerated all test data.

New expiration date: 2026-07-18T08:24:13Z

Signed-off-by: 0xiso <[email protected]>
@0xiso 0xiso force-pushed the fix/update-expired-test-data branch from 9275113 to e09f67f Compare January 18, 2026 09:09
@0xiso
Copy link
Contributor Author

0xiso commented Jan 18, 2026

@hectorj2f Thanks for the feedback! I've reverted the PR to its initial state.

This PR regenerates all the testdata files using go run hack/gentestdata/gentestdata.go and updates the hardcoded base64 values in both trustroot_validation_test.go and repo_test.go. This matches the approach taken in #1857, which also updated the same set of 16 files.

All tests are passing.

@hectorj2f hectorj2f merged commit c1a32c2 into sigstore:main Jan 21, 2026
94 of 95 checks passed
@github-actions github-actions bot added this to the v1 milestone Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants