-
Notifications
You must be signed in to change notification settings - Fork 70
fix: update expired TUF test data #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1920 +/- ##
===========================================
- Coverage 42.78% 29.98% -12.80%
===========================================
Files 121 122 +1
Lines 8994 7323 -1671
===========================================
- Hits 3848 2196 -1652
- Misses 4791 4894 +103
+ Partials 355 233 -122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hectorj2f
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should only need to update two files as done in here https://github.com/sigstore/policy-controller/pull/1496/files
|
@hectorj2f I followed the example in that PR and updated only the two files, however the tests are failing. Am I missing any additional changes that are required? |
|
It looks like we must update it now in additional places too https://github.com/sigstore/policy-controller/actions/runs/20930413044/job/60139572158?pr=1920 |
3f601da to
9275113
Compare
The TUF root.json test data had expired (2026-01-01T11:46:29Z), causing test failures. Regenerated all test data. New expiration date: 2026-07-18T08:24:13Z Signed-off-by: 0xiso <[email protected]>
9275113 to
e09f67f
Compare
|
@hectorj2f Thanks for the feedback! I've reverted the PR to its initial state. This PR regenerates all the testdata files using All tests are passing. |
This PR updates the expired TUF test data which was causing test failures.
Changes
pkg/reconciler/trustroot/testdata/root.jsonandpkg/reconciler/trustroot/testdata/tufRepo.tarusingmake generate-testdata.pkg/apis/policy/v1alpha1/trustroot_validation_test.goandpkg/tuf/repo_test.go.Files Modified (Manually)
pkg/apis/policy/v1alpha1/trustroot_validation_test.gopkg/tuf/repo_test.goCommands Run
make generate-testdata