Use an alternative form to mark oneof fields as required #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fredrik Skogman <[email protected]>
kommendorkapten
force-pushed
the
oneof_required_fix
branch
from
75cdaf8 to
6365703
Compare
haydentherapper
previously approved these changes
May 29, 2024
Collaborator
haydentherapper
left a comment
haydentherapper
left a comment
There was a problem hiding this comment.
Great find for the fix. Do we need to test this with all language clients?
Collaborator
|
Dismissing my review, seems like this isn't WAI according to sigstore/sigstore-go#63 (comment) |
Member
Author
|
@haydentherapper yes, I did see in the other PR that this was fully WAI, I haven't had time to dig into this. My fear is that relying on annotations for verifying field behaviour may differ between clients :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use an alternative and updated method to mark
oneoffields asREQUIRED.Closes: #336
Release Note
oneoffields are marked asREQUIREDin the protobufDocumentation
N/A