Skip to content

Conversation

@fghanmi
Copy link
Contributor

@fghanmi fghanmi commented Dec 5, 2025

Summary

This update removes the previously hardcoded CTlog key ID and instead dynamically selects the correct CTlog verifier based on the CTlog's BaseURL. It also fixes the issue where STHs generated by the monitor contained an empty log_id field by correctly computing the log ID as the SHA-256 hash of the DER-encoded public key. These changes allow ct_monitor to work properly with both custom CT logs and the public Sigstore CT log instances.

This PR also includes a variable rename, fulcioClient -> ctlogClient

Issue: #829

Release Note

Documentation

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 16.12903% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.75%. Comparing base (d271ec7) to head (85f45de).
⚠️ Report is 428 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ct/consistency.go 18.51% 20 Missing and 2 partials ⚠️
cmd/ct_monitor/main.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #830       +/-   ##
===========================================
- Coverage   64.02%   35.75%   -28.28%     
===========================================
  Files           4       24       +20     
  Lines         303     2302     +1999     
===========================================
+ Hits          194      823      +629     
- Misses         78     1382     +1304     
- Partials       31       97       +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants