-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Add sigstore-rs client test #1434
Conversation
I think we could leave this after the repository has been fixed: theupdateframework/tuf-on-ci#536 should be enough to guaranteethat the signing event is good. |
* This test is not in root-signing-staging since the client does not support staging * Uses current main HEAD since last release does not have the "bundle" example we use * Does not test signing since the client does not support signing with the GitHub Actions workflow identity This test currently fails because of sigstore#1431: sigstore-rs expects specifically computed TUF keyids which current root metadata does not provide. Signed-off-by: Jussi Kukkonen <[email protected]>
This sigstore-rs branch contains the v12 root so allows testing when v12 is getting published Signed-off-by: Jussi Kukkonen <[email protected]>
Changes:
The idea here is that if everything works well, we get sigstore-rs tests running in the publishing pipeline. If something fails during publish, we can fix issues in the test workflow or even remove the sigstore-rs test if we decide so without redoing the signing event -- but we won't have another root update that breaks something without our knowledge. |
I guess it's reasonable to mention why I said that: the workflow has never been tested because it can only possibly work after the next online signing. So there is a chance of bugs here. |
# TODO: Just use a released sigstore-rs when possible | ||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
with: | ||
repository: "jku/sigstore-rs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would your change need to be merged into upstream sigstore-rs after this so we can depend on that instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I would expect
- root v12 change gets merged in sigstore-rs after we publish
- sigstore-rs makes a release
- we can start using the released sigstore-rs (maybe even via cargo and not actions checkout)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets try this out. The key id mismatch is the last known issue to me for sigstore-rs. Ans as it's quite complex to organize and test as @jku explains. This is the option with the fewest steps.
Testing this is an issue:
Setting as draft for now: let's figure out what we do with 1431.