tests: Remove sigstore-rs client test #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sigstore-rs does not support signing in GitHub Actions so we need to test verify with a bundle made by another client * There is a signature bundle available for this purpose. It's produced by sigstore-python so is bundle v0.3: sigstore-rs only support <=0.2 We've tested manually and the test commands succeed when the bundle is v0.2 but we're not keen to make the tests more complicated: Remove sigstore-rs tests for now. Signed-off-by: Jussi Kukkonen <[email protected]>
kommendorkapten
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've tested manually and the test commands succeed when the bundle is v0.2 but we're not keen to make the tests more complicated: Remove sigstore-rs tests for now.