-
Notifications
You must be signed in to change notification settings - Fork 25
fix(deps): update dependency commons-codec:commons-codec to v1.20.0 #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
vlsi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a real reason to use commons-codec?
We should rather drop the dependency to avoid CVEs
|
Ah, it is used in transitive dependencies: Unfortunately, httpclient4 is not supported, so there's no way to remove commons-codec dependency while http-client 5 already has removed commons-codec dependency. |
|
there is a v5 pathway: https://github.com/googleapis/google-http-java-client/tree/main/google-http-client-apache-v5 , probably going to need to look into how to use that instead. |
01972d4 to
375c59b
Compare
|
it seems like ideally we would just move off of google-http-client? |
375c59b to
f385a72
Compare
f385a72 to
e20dcc7
Compare
|
If you are ok to move off google-http-client, then it might be a workable solution as well |
|
Google-http-client was convenient at the time (especially for oidc). But we have no attachment to it. I have a half done branch just using apache http client directly. I'll see how that goes |
This PR contains the following updates:
1.18.0->1.20.0Release Notes
apache/commons-codec (commons-codec:commons-codec)
v1.20.0The Apache Commons Codec team is pleased to announce the release of Apache Commons Codec 1.20.0.
The Apache Commons Codec component contains encoders and decoders for
formats such as Base16, Base32, Base64, digest, and Hexadecimal. In addition to these
widely used encoders and decoders, the codec package also maintains a
collection of phonetic encoding utilities.
This is a feature and maintenance release. Java 8 or later is required.
Configuration
📅 Schedule: Branch creation - "every 3 weeks on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.