Skip to content

Fix BoringSSL compatibility for Bun runtime #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keithagroves wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix BoringSSL compatibility for Bun runtime #1516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bun-boringssl-compatibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sigstore/sign': patch
---

Fix BoringSSL compatibility for Bun runtime. The ephemeral signer now explicitly uses SHA-256 as the digest algorithm instead of relying on implicit defaults, enabling @sigstore/sign to work with Bun's BoringSSL implementation.
6 changes: 3 additions & 3 deletions packages/sign/src/signer/fulcio/ephemeral.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
import crypto, { KeyPairKeyObjectResult } from 'crypto';
import { generateKeyPairSync, sign, KeyPairKeyObjectResult } from 'crypto';

import type { Signature, Signer } from '../signer';

Expand All @@ -27,13 +27,13 @@ export class EphemeralSigner implements Signer {
private keypair: KeyPairKeyObjectResult;

constructor() {
this.keypair = crypto.generateKeyPairSync(EC_KEYPAIR_TYPE, {
this.keypair = generateKeyPairSync(EC_KEYPAIR_TYPE, {
namedCurve: P256_CURVE,
});
}

public async sign(data: Buffer): Promise<Signature> {
const signature = crypto.sign(null, data, this.keypair.privateKey);
const signature = sign('sha256', data, this.keypair.privateKey);
const publicKey = this.keypair.publicKey
.export({ format: 'pem', type: 'spki' })
.toString('ascii');
Expand Down