Fix in-toto statement verification (GHSA-mhg6-2q2v-9h2c)#300
Merged
bobcallaway merged 2 commits intomainfrom Mar 9, 2026
Merged
Fix in-toto statement verification (GHSA-mhg6-2q2v-9h2c)#300bobcallaway merged 2 commits intomainfrom
bobcallaway merged 2 commits intomainfrom
Conversation
* verifier: properly verify in-toto statement This patch fixes four problems in in-toto statement verification. - The result of in-toto statement verification was not used at all, so otherwise legitimate bundle passes verification for any inputs. - When the in-toto statement contains multiple subjects, the bundle was mistakenly considered as invalid. - When the in-toto statement contains subject digests of multiple hash algorithms, the statement might be mistakenly rejected. - When comparing subject digests, it did not check the algorithm matches (hash collision with different algorithm is unlikely though). * run rubocop Signed-off-by: Bob Callaway <bcallaway@google.com> --------- Signed-off-by: Bob Callaway <bcallaway@google.com> Co-authored-by: Kasumi Hanazuki <kasumi@rollingapple.net> Co-authored-by: Bob Callaway <bcallaway@google.com>
bobcallaway
previously approved these changes
Mar 9, 2026
Signed-off-by: Hayden <8418760+Hayden-IO@users.noreply.github.com>
bobcallaway
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes four problems in in-toto statement verification.