ci: Modify build actions to include benchmarks.#720
Merged
Conversation
Contributor
Author
|
I don't think I appreciated that Check runs first so I'm going to split it out. |
jdmarshall
force-pushed
the
benchmark
branch
2 times, most recently
from
5ffaec2 to
483ea2c
Compare
Given the tendency of people to submit PRs that claim performance improvements, it would be good to actually run the benchmarks.
jdmarshall
force-pushed
the
benchmark
branch
from
2e9bc22 to
3cf9a86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed while looking through the open PRs that the benchmark results aren't being included in the PRs.
Given the tendency of people to submit PRs that claim performance improvements, it would be good to actually run the benchmarks.