Parse user id from notifications#116
Merged
Merged
Conversation
The user_id (if present) will get recorder in dirtylog.
Code coverage report for 4a17aa0Coverage difference❌ Code coverage worsened.
Overall coverageClick to expand
HTML reports |
j4r0u53k
force-pushed
the
parse-user-id-from-notifications
branch
from
1fd0fa4 to
d674fb2
Compare
The previous implementation used `Path::ends_with`, which checks for full path components rather than string suffixes. This caused `.log3` files to be misidentified as version 2 logs. Switched to string-based suffix checking using `to_string_lossy()` to ensure the correct reader is initialized.
j4r0u53k
force-pushed
the
parse-user-id-from-notifications
branch
from
d674fb2 to
4a17aa0
Compare
syyyr
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.