Fix filename format#37
Merged
Merged
Conversation
Code coverage report for 071fa6bCoverage difference❌ Code coverage worsened.
Overall coverageClick to expand
HTML reportsYou can use GitHub CLI to download HTML coverage reports and open them automatically using this command: (cd "$(mktemp -d)" && gh run -R silicon-heaven/historyprovider-rs download -n historyprovider-rs-cov-html-071fa6b8a1c9f8550bfafb5590b83306ed37cbf4 && ls -1 | xargs -n1 xdg-open)You can download the HTML reports manually here. |
8836431 to
2b70026
Compare
We use this format: 2025-10-12T01-00-00-000.log2, but we were writing 2025-10-12T01:00:00.log2
2b70026 to
5c0174c
Compare
b1958ee to
f7962ac
Compare
j4r0u53k
requested changes
Oct 29, 2025
j4r0u53k
requested changes
Oct 29, 2025
f7962ac to
145ecfa
Compare
j4r0u53k
requested changes
Oct 29, 2025
Our format is 2025-10-12T01-00-00-000.log2, not 2025-10-12T01:00:00.log2.
145ecfa to
071fa6b
Compare
j4r0u53k
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.