Skip to content

Fix filename format#37

Merged
j4r0u53k merged 3 commits into
mainfrom
fix-filename-format
Oct 29, 2025
Merged

Fix filename format#37
j4r0u53k merged 3 commits into
mainfrom
fix-filename-format

Conversation

@syyyr
Copy link
Copy Markdown
Collaborator

@syyyr syyyr commented Oct 27, 2025

No description provided.

@syyyr syyyr requested a review from j4r0u53k October 27, 2025 10:51
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 27, 2025

Code coverage report for 071fa6b

Coverage difference

❌ Code coverage worsened.

Filename Stmts Miss Cover Missing
src/tree.rs +4 +4 -0.12% 802, 803, 804, 805, 807, 808, 810, 811, 865
TOTAL +4 +4 -0.05%

Overall coverage

Click to expand
Filename Stmts Miss Cover Missing
src/bin/hp.rs 51 51 0.00% 44-106
src/sync/tests.rs 180 0 100.00%
src/alarm.rs 225 80 64.44% 28-38, 44-46, 49-50, 56-124, 130, 136, 140-148, 157, 199, 229
src/dirtylog.rs 423 22 94.80% 72, 95-99, 106-107, 122, 131-133, 147-151, 188-192, 200-201, 232
src/tree.rs 1399 815 41.74% 107-998, 1123, 1133-1139, 1184, 1188-1192, 1219-1361
src/typeinfo.rs 632 283 55.22% 33-34, 66-68, 74, 97-99, 107, 114-115, 128, 132, 140, 153-206, 212-214, 220-238, 258, 271, 280-282, 286-288, 313-328, 343-344, 361-362, 373-378, 384, 392, 425-427, 430-432, 448-454, 499-512, 535-537, 576-595, 620-622, 629-750, 767-773, 783-795, 904-906, 913, 923, 933-935, 943-949, 988-996, 1006-1022, 1034-1036
src/util.rs 284 49 82.75% 36, 63-64, 67-70, 72, 97, 153-176, 190, 207, 229, 234-244, 248, 259, 266, 273, 300, 314, 448-453
src/sync.rs 648 253 60.96% 61-62, 72, 80, 88, 97, 148, 150-151, 170, 175, 191, 234-240, 315-332, 339-341, 352-361, 436, 484-698, 721, 779, 786-809, 819, 824, 861-880, 884, 888-898
src/lib.rs 42 42 0.00% 29-110
src/cleanup.rs 52 24 53.85% 51-90
src/datachange.rs 110 6 94.55% 79-83, 88
src/sites.rs 571 116 79.68% 59, 166-198, 210-211, 231-263, 294-306, 380, 413-414, 419-426, 484-490, 520-533, 541, 573-575, 579, 583, 596-599, 605-607, 611, 626-633
src/journalrw.rs 540 107 80.19% 78, 102, 143, 165, 172, 181, 195, 203-206, 213, 236-244, 260, 288-290, 304-341, 363-368, 372, 375, 389, 392-396, 401, 405-406, 411-412, 416-417, 421-422, 443-445, 465-466, 488-514, 524-525, 529-530, 534-535, 539-540, 544-545, 549-550, 554-555, 559-560, 570-571, 575, 580-581, 696
TOTAL 5157 1848 64.17%

HTML reports

You can use GitHub CLI to download HTML coverage reports and open them automatically using this command:

(cd "$(mktemp -d)" && gh run -R silicon-heaven/historyprovider-rs download -n historyprovider-rs-cov-html-071fa6b8a1c9f8550bfafb5590b83306ed37cbf4 && ls -1 | xargs -n1 xdg-open)

You can download the HTML reports manually here.

@syyyr syyyr force-pushed the fix-filename-format branch from 8836431 to 2b70026 Compare October 27, 2025 11:30
@syyyr syyyr marked this pull request as draft October 27, 2025 11:48
syyyr added 2 commits October 27, 2025 12:50
We use this format: 2025-10-12T01-00-00-000.log2, but we were writing
2025-10-12T01:00:00.log2
@syyyr syyyr force-pushed the fix-filename-format branch from 2b70026 to 5c0174c Compare October 27, 2025 11:50
@syyyr syyyr marked this pull request as ready for review October 27, 2025 11:50
@syyyr syyyr force-pushed the fix-filename-format branch 2 times, most recently from b1958ee to f7962ac Compare October 27, 2025 14:24
Comment thread src/tree.rs Outdated
Comment thread src/tree.rs Outdated
@syyyr syyyr force-pushed the fix-filename-format branch from f7962ac to 145ecfa Compare October 29, 2025 12:14
@syyyr syyyr requested a review from j4r0u53k October 29, 2025 12:14
Comment thread src/tree.rs Outdated
Comment thread src/tree.rs Outdated
Our format is 2025-10-12T01-00-00-000.log2, not 2025-10-12T01:00:00.log2.
@syyyr syyyr force-pushed the fix-filename-format branch from 145ecfa to 071fa6b Compare October 29, 2025 12:43
@syyyr syyyr requested a review from j4r0u53k October 29, 2025 12:43
@j4r0u53k j4r0u53k merged commit 75da50a into main Oct 29, 2025
2 checks passed
@j4r0u53k j4r0u53k deleted the fix-filename-format branch October 29, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants