Crash if sites root node doesn't have an HP3 key#41
Merged
Conversation
Code coverage report for 6b18e63Coverage difference❌ Code coverage worsened.
Overall coverageClick to expand
HTML reportsYou can use GitHub CLI to download HTML coverage reports and open them automatically using this command: (cd "$(mktemp -d)" && gh run -R silicon-heaven/historyprovider-rs download -n historyprovider-rs-cov-html-6b18e63a358ae0b0992b26e2687c21538289dae4 && ls -1 | xargs -n1 xdg-open)You can download the HTML reports manually here. |
j4r0u53k
requested changes
Oct 31, 2025
e205e7b to
3c982ba
Compare
j4r0u53k
approved these changes
Nov 3, 2025
The root node must have an HP3 key, otherwise this HP is not visible to parent instances.
3c982ba to
6b18e63
Compare
j4r0u53k
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root node must have an HP3 key, otherwise this HP is not visible to parent instances.