Skip to content

Crash if sites root node doesn't have an HP3 key#41

Merged
j4r0u53k merged 1 commit into
mainfrom
crash-if-no-root-hp3-key
Nov 3, 2025
Merged

Crash if sites root node doesn't have an HP3 key#41
j4r0u53k merged 1 commit into
mainfrom
crash-if-no-root-hp3-key

Conversation

@syyyr
Copy link
Copy Markdown
Collaborator

@syyyr syyyr commented Oct 30, 2025

The root node must have an HP3 key, otherwise this HP is not visible to parent instances.

@syyyr syyyr requested a review from j4r0u53k October 30, 2025 09:55
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 30, 2025

Code coverage report for 6b18e63

Coverage difference

❌ Code coverage worsened.

Filename Stmts Miss Cover Missing
src/sites.rs +16 +2 +0.21% 417, 418
TOTAL +16 +2 +0.07%

Overall coverage

Click to expand
Filename Stmts Miss Cover Missing
src/bin/hp.rs 51 51 0.00% 44-106
src/typeinfo.rs 819 262 68.01% 70-72, 101-103, 111, 118-119, 132, 136, 144, 157-210, 216-218, 224-242, 262, 275, 290-292, 317-332, 347-348, 365-366, 377-382, 388, 396, 430-431, 452-458, 503-516, 580-599, 624-626, 653-664, 690-691, 702-732, 762-764, 785-787, 801-813, 921-923, 930, 940, 950-952, 960-966, 986-1001, 1022-1030, 1042-1051, 1063, 1086-1088, 1105, 1142, 1145, 1150-1151, 1188-1189, 1192-1193, 1200, 1220-1222, 1226-1230, 1234-1236
src/util.rs 284 49 82.75% 36, 63-64, 67-70, 72, 97, 153-176, 190, 207, 229, 234-244, 248, 259, 266, 273, 300, 314, 448-453
src/journalrw.rs 540 107 80.19% 78, 102, 143, 165, 172, 181, 195, 203-206, 213, 236-244, 260, 288-290, 304-341, 363-368, 372, 375, 389, 392-396, 401, 405-406, 411-412, 416-417, 421-422, 443-445, 465-466, 488-514, 524-525, 529-530, 534-535, 539-540, 544-545, 549-550, 554-555, 559-560, 570-571, 575, 580-581, 696
src/alarm.rs 225 80 64.44% 28-38, 44-46, 49-50, 56-124, 130, 136, 140-148, 157, 199, 229
src/datachange.rs 110 6 94.55% 79-83, 88
src/tree.rs 1432 848 40.78% 109-1031, 1156, 1166-1172, 1217, 1221-1225, 1252-1399
src/sites.rs 587 118 79.90% 59, 166-198, 210-211, 231-263, 294-306, 380, 417-418, 426-427, 432-439, 497-503, 533-546, 554, 586-588, 592, 596, 609-612, 618-620, 624, 639-646
src/dirtylog.rs 423 22 94.80% 72, 95-99, 106-107, 122, 131-133, 147-151, 188-192, 200-201, 232
src/cleanup.rs 52 24 53.85% 51-90
src/lib.rs 42 42 0.00% 29-110
src/sync.rs 648 253 60.96% 61-62, 72, 80, 88, 97, 148, 150-151, 170, 175, 191, 234-240, 315-332, 339-341, 352-361, 436, 484-698, 721, 779, 786-809, 819, 824, 861-880, 884, 888-898
src/sync/tests.rs 180 0 100.00%
TOTAL 5393 1862 65.47%

HTML reports

You can use GitHub CLI to download HTML coverage reports and open them automatically using this command:

(cd "$(mktemp -d)" && gh run -R silicon-heaven/historyprovider-rs download -n historyprovider-rs-cov-html-6b18e63a358ae0b0992b26e2687c21538289dae4 && ls -1 | xargs -n1 xdg-open)

You can download the HTML reports manually here.

Comment thread src/sites.rs
Comment thread src/sites.rs Outdated
@syyyr syyyr force-pushed the crash-if-no-root-hp3-key branch from e205e7b to 3c982ba Compare November 3, 2025 10:07
The root node must have an HP3 key, otherwise this HP is not visible to parent
instances.
@syyyr syyyr force-pushed the crash-if-no-root-hp3-key branch from 3c982ba to 6b18e63 Compare November 3, 2025 11:49
@j4r0u53k j4r0u53k merged commit b742ca8 into main Nov 3, 2025
2 checks passed
@j4r0u53k j4r0u53k deleted the crash-if-no-root-hp3-key branch November 3, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants