Skip to content

Switch to libshvclient 0.20 method handlers API#51

Merged
syyyr merged 1 commit into
mainfrom
switch-to-libshvclient-0-20
Dec 3, 2025
Merged

Switch to libshvclient 0.20 method handlers API#51
syyyr merged 1 commit into
mainfrom
switch-to-libshvclient-0-20

Conversation

@j4r0u53k
Copy link
Copy Markdown
Collaborator

@j4r0u53k j4r0u53k commented Dec 2, 2025

Replace deprecated split methods_getter/request_handler API with the new one introduced in libshvclient 0.20.

Each dynamic node implements one request handler that resolves its methods and returns requested method handler in the result.

Replace deprecated split methods_getter/request_handler API
with the new one introduced in libshvclient 0.20.

Each dynamic node implements one request handler that resolves
its methods and returns requested method handler in the result.
@j4r0u53k j4r0u53k force-pushed the switch-to-libshvclient-0-20 branch from 1b3c863 to 829073a Compare December 2, 2025 16:11
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2025

Code coverage report for 829073a

Coverage difference

⚠️ There are new lines with missing coverage.

Filename Stmts Miss Cover Missing
src/lib.rs -1 -1 +100.00% 90, 103, 104, 106
src/tree.rs -207 -207 +100.00% 107, 108, 109, 110, 111, 112, 113, 119, 121, 122, 123, 124, 125, 127, 128, 129, 130, 131, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 151, 152, 153, 154, 155, 156, 157, 158, 160, 177, 206, 208, 211, 213, 214, 215, 216, 218, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 242, 243, 244, 245, 247, 248, 249, 250, 251, 252, 254, 256, 260, 261, 262, 264, 266, 267, 268, 269, 270, 271, 272, 273, 274, 276, 283, 284, 285, 286, 287, 288, 291, 293, 302, 303, 304, 305, 307, 318, 319, 320, 324, 325, 326, 329, 330, 331, 333, 334, 335, 336, 337, 339, 340, 341, 344, 345, 346, 349, 350, 351, 352, 353, 355, 356, 358, 359, 360, 361, 363, 364, 365, 366, 367, 370, 382, 383, 384, 463, 464, 478, 479, 526, 527, 541, 542, 549, 550, 551, 553, 554, 557, 558, 564, 565, 566, 567, 568, 571, 573, 574, 575, 576, 577, 582, 588, 589, 590, 591, 592, 610, 611, 612, 613, 614, 615, 616, 617, 620, 621, 622, 623, 625, 626, 627, 628, 629, 630, 631, 632, 633, 634, 638, 639, 640, 641, 642, 643, 644, 645, 646, 648, 650, 651, 653, 656, 661, 664, 665, 666, 667, 668, 669, 670, 671, 673, 674, 675, 676, 677, 678, 679, 680, 683
src/util.rs -2 -2 +0.58% 233
TOTAL -210 -210 +2.60%

Overall coverage

Click to expand
Filename Stmts Miss Cover Missing
src/sync/tests.rs 180 0 100.00%
src/bin/hp.rs 51 51 0.00% 44-106
src/alarmlog.rs 64 64 0.00% 29-103
src/journalrw.rs 540 107 80.19% 78, 102, 143, 165, 172, 181, 195, 203-206, 213, 236-244, 260, 288-290, 304-341, 363-368, 372, 375, 389, 392-396, 401, 405-406, 411-412, 416-417, 421-422, 443-445, 465-466, 488-514, 524-525, 529-530, 534-535, 539-540, 544-545, 549-550, 554-555, 559-560, 570-571, 575, 580-581, 696
src/sync.rs 648 253 60.96% 61-62, 72, 80, 88, 97, 148, 150-151, 170, 175, 191, 234-240, 315-332, 339-341, 352-361, 436, 484-698, 721, 779, 786-809, 819, 824, 861-880, 884, 888-898
src/lib.rs 43 43 0.00% 32-114
src/alarm.rs 236 86 63.56% 28-38, 44-46, 49-50, 56-124, 140-142, 149-151, 156, 162, 166-174, 183, 224, 254
src/dirtylog.rs 423 22 94.80% 73, 96-100, 107-108, 123, 132-134, 148-152, 189-193, 201-202, 233
src/cleanup.rs 52 24 53.85% 51-90
src/datachange.rs 110 6 94.55% 79-83, 88
src/pushlog.rs 107 107 0.00% 21-164
src/sites.rs 596 125 79.03% 60, 168-200, 212-213, 233-265, 296-308, 382, 419-420, 428-429, 434-441, 499-505, 536-554, 563, 593-595, 599, 603, 616-619, 625-627, 631, 646-657
src/tree.rs 412 412 0.00% 72-687
src/typeinfo.rs 827 265 67.96% 71-73, 102-104, 112, 119-120, 133, 137, 145, 158-211, 217-219, 225-243, 263, 276, 291-293, 297-299, 324-339, 354-355, 372-373, 384-389, 395, 403, 437-438, 459-465, 510-523, 588-607, 632-634, 661-672, 698-699, 710-740, 770-772, 793-795, 809-821, 929-931, 938, 948, 958-960, 968-974, 994-1009, 1030-1038, 1050-1059, 1071, 1094-1096, 1113, 1150, 1153, 1158-1159, 1196-1197, 1200-1201, 1208, 1228-1230, 1234-1238, 1242-1244
src/util.rs 284 47 83.45% 35, 62-63, 66-69, 71, 96, 152-175, 189, 206, 228, 233-241, 245, 256, 263, 270, 297, 311, 447-452
src/getlog.rs 675 91 86.52% 34-133, 245, 255-261, 306, 310-314
TOTAL 5248 1703 67.55%

HTML reports

You can use GitHub CLI to download HTML coverage reports and open them automatically using this command:

(cd "$(mktemp -d)" && gh run -R silicon-heaven/historyprovider-rs download -n historyprovider-rs-cov-html-829073af47871bcebf53b6ade1743e4d53187ad4 && ls -1 | xargs -n1 xdg-open)

You can download the HTML reports manually here.

@j4r0u53k j4r0u53k requested review from fvacek and syyyr December 2, 2025 16:19
@syyyr syyyr merged commit fbfcc85 into main Dec 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants