Switch to libshvclient 0.20 method handlers API#51
Merged
Conversation
Replace deprecated split methods_getter/request_handler API with the new one introduced in libshvclient 0.20. Each dynamic node implements one request handler that resolves its methods and returns requested method handler in the result.
1b3c863 to
829073a
Compare
Code coverage report for 829073aCoverage difference
Overall coverageClick to expand
HTML reportsYou can use GitHub CLI to download HTML coverage reports and open them automatically using this command: (cd "$(mktemp -d)" && gh run -R silicon-heaven/historyprovider-rs download -n historyprovider-rs-cov-html-829073af47871bcebf53b6ade1743e4d53187ad4 && ls -1 | xargs -n1 xdg-open)You can download the HTML reports manually here. |
fvacek
approved these changes
Dec 3, 2025
syyyr
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace deprecated split methods_getter/request_handler API with the new one introduced in libshvclient 0.20.
Each dynamic node implements one request handler that resolves its methods and returns requested method handler in the result.