Skip to content

Adopt new method-resolver API from libshvclient#52

Merged
fvacek merged 1 commit into
mainfrom
improve-method-resolve
Dec 8, 2025
Merged

Adopt new method-resolver API from libshvclient#52
fvacek merged 1 commit into
mainfrom
improve-method-resolve

Conversation

@j4r0u53k
Copy link
Copy Markdown
Collaborator

@j4r0u53k j4r0u53k commented Dec 8, 2025

Switch request dispatching from the old string-based method matching to the new strong typed API.
This adoption strengthens type-checking, eliminates the need to manually return method names, and removes redundant Ok(...) wrapping.

@j4r0u53k j4r0u53k requested review from fvacek and syyyr December 8, 2025 13:24
Switch request dispatching from the old string-based method matching
to the new strong typed API.
This adoption strengthens type-checking, eliminates the need to manually
return method names, and removes redundant Ok(...) wrapping.
@j4r0u53k j4r0u53k force-pushed the improve-method-resolve branch from 70d11e6 to 3c3be17 Compare December 8, 2025 13:25
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 8, 2025

Code coverage report for 3c3be17

Coverage difference

❌ Code coverage worsened.

Filename Stmts Miss Cover Missing
src/tree.rs +3 +3 +100.00% 109, 112, 214, 229, 230, 231, 233, 234, 235, 236, 237, 238, 239, 242, 244, 245, 246, 247, 249, 250, 251, 252, 253, 254, 256, 265, 266, 270, 271, 272, 274, 275, 277, 278, 287, 288, 289, 290, 291, 292, 293, 294, 298, 572, 575, 580, 581, 582, 583, 584, 595, 596, 597, 598, 599, 617, 618, 619, 630, 632, 633, 634, 635, 636, 637, 638, 639, 640, 641, 642, 650, 673, 674, 675, 676, 680, 682, 683, 684, 685, 686, 687, 688
TOTAL +3 +3 -0.04%

Overall coverage

Click to expand
Filename Stmts Miss Cover Missing
src/bin/hp.rs 51 51 0.00% 44-106
src/sync/tests.rs 180 0 100.00%
src/lib.rs 43 43 0.00% 32-114
src/pushlog.rs 107 107 0.00% 21-164
src/tree.rs 415 415 0.00% 73-693
src/sync.rs 648 253 60.96% 61-62, 72, 80, 88, 97, 148, 150-151, 170, 175, 191, 234-240, 315-332, 339-341, 352-361, 436, 484-698, 721, 779, 786-809, 819, 824, 861-880, 884, 888-898
src/util.rs 284 47 83.45% 35, 62-63, 66-69, 71, 96, 152-175, 189, 206, 228, 233-241, 245, 256, 263, 270, 297, 311, 447-452
src/datachange.rs 110 6 94.55% 79-83, 88
src/getlog.rs 675 91 86.52% 34-133, 245, 255-261, 306, 310-314
src/alarm.rs 236 86 63.56% 28-38, 44-46, 49-50, 56-124, 140-142, 149-151, 156, 162, 166-174, 183, 224, 254
src/journalrw.rs 540 107 80.19% 78, 102, 143, 165, 172, 181, 195, 203-206, 213, 236-244, 260, 288-290, 304-341, 363-368, 372, 375, 389, 392-396, 401, 405-406, 411-412, 416-417, 421-422, 443-445, 465-466, 488-514, 524-525, 529-530, 534-535, 539-540, 544-545, 549-550, 554-555, 559-560, 570-571, 575, 580-581, 696
src/cleanup.rs 52 24 53.85% 51-90
src/alarmlog.rs 64 64 0.00% 29-103
src/dirtylog.rs 423 22 94.80% 73, 96-100, 107-108, 123, 132-134, 148-152, 189-193, 201-202, 233
src/sites.rs 596 125 79.03% 60, 168-200, 212-213, 233-265, 296-308, 382, 419-420, 428-429, 434-441, 499-505, 536-554, 563, 593-595, 599, 603, 616-619, 625-627, 631, 646-657
src/typeinfo.rs 827 265 67.96% 71-73, 102-104, 112, 119-120, 133, 137, 145, 158-211, 217-219, 225-243, 263, 276, 291-293, 297-299, 324-339, 354-355, 372-373, 384-389, 395, 403, 437-438, 459-465, 510-523, 588-607, 632-634, 661-672, 698-699, 710-740, 770-772, 793-795, 809-821, 929-931, 938, 948, 958-960, 968-974, 994-1009, 1030-1038, 1050-1059, 1071, 1094-1096, 1113, 1150, 1153, 1158-1159, 1196-1197, 1200-1201, 1208, 1228-1230, 1234-1238, 1242-1244
TOTAL 5251 1706 67.51%

HTML reports

You can use GitHub CLI to download HTML coverage reports and open them automatically using this command:

(cd "$(mktemp -d)" && gh run -R silicon-heaven/historyprovider-rs download -n historyprovider-rs-cov-html-3c3be17a96903ec9b656b561eb82ca070e7f46a6 && ls -1 | xargs -n1 xdg-open)

You can download the HTML reports manually here.

@fvacek fvacek merged commit 2c53d20 into main Dec 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants