Unify configs#65
Merged
Merged
Conversation
Remove `--hp-config` option and use just `--config`. HP specific options can be overriden from command line.
bd07a1c to
f20e0ec
Compare
Code coverage report for e9ffb75Coverage difference❌ Code coverage worsened.
Overall coverageClick to expand
HTML reportsYou can use GitHub CLI to download HTML coverage reports and open them automatically using this command: (cd "$(mktemp -d)" && gh run -R silicon-heaven/historyprovider-rs download -n historyprovider-rs-cov-html-e9ffb75f86d03ab2f52b94e78ce76d38090fc182 && ls -1 | xargs -n1 xdg-open)You can download the HTML reports manually here. |
fvacek
requested changes
Jan 13, 2026
Centralize default values for sync limits, journal size, and intervals.
fvacek
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
--hp-configoption and use just--config. HP specific options can be overriden from command line.