Correctly report numeric overflow and clarify error semantics#100
Merged
Conversation
Code coverage report for cd20296Coverage difference
Overall coverageClick to expand
HTML reportsYou can use GitHub CLI to download HTML coverage reports and open them automatically using this command: (cd "$(mktemp -d)" && gh run -R silicon-heaven/libshvproto-rs download -n libshvproto-cov-html-cd20296db96f6b7fba2e83bcd51188ac587c943a && ls -1 | xargs -n1 xdg-open)You can download the HTML reports manually here. |
Fixes a bug where ReadErrorReason::NotEnoughPrecision was never constructed. NotEnoughPrecision renamed to NumericValueOverflow for clearer semantics. Replaced magic decimal threshold with equivalent hex literal (0x80000000000000) for better readability.
f42e7a7 to
cd20296
Compare
syyyr
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where ReadErrorReason::NotEnoughPrecision was never constructed.
NotEnoughPrecision renamed to NumericValueOverflow for clearer semantics.
Replaced magic decimal threshold with equivalent hex literal (0x80000000000000) for better readability.