Skip to content

Cq#89

Merged
syyyr merged 6 commits into
masterfrom
cq
Jan 6, 2026
Merged

Cq#89
syyyr merged 6 commits into
masterfrom
cq

Conversation

@syyyr

@syyyr syyyr commented Dec 24, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@syyyr syyyr requested a review from fvacek December 24, 2025 00:32
@syyyr

syyyr commented Dec 24, 2025

Copy link
Copy Markdown
Contributor Author

Support is incomplete. :) you can feel free to improve the support by implementing a todo() function or extending the existing functions to accept more match arms before the default Error arm

@syyyr

syyyr commented Dec 24, 2025

Copy link
Copy Markdown
Contributor Author

Tests are missing

@github-actions

github-actions Bot commented Dec 24, 2025

Copy link
Copy Markdown

Code coverage report for 435d136

Coverage difference

❌ Code coverage worsened.

Filename Stmts Miss Cover Missing
src/bin/cp2cp.rs +17 -4 +8.67% 171, 172, 173, 182, 183, 184, 188, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 213, 214
src/jaq.rs +180 +173 +3.89% 11, 12, 13, 14, 16, 21, 22, 23, 24, 25, 27, 32, 33, 34, 35, 36, 38, 43, 44, 45, 46, 48, 53, 54, 55, 56, 58, 63, 64, 65, 66, 68, 72, 73, 74, 79, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 116, 120, 121, 122, 126, 127, 128, 129, 130, 134, 135, 136, 140, 141, 142, 143, 145, 147, 148, 149, 151, 152, 153, 154, 156, 158, 159, 162, 163, 166, 167, 170, 171, 174, 175, 180, 181, 182, 184, 185, 186, 188, 189, 190, 191, 192, 193, 194, 196, 197, 198, 199, 201, 202, 203, 204, 206, 208, 210, 211, 212, 213, 214, 215, 217, 218, 219, 220, 222, 223, 224, 225, 227, 229, 237, 241, 242, 245, 246, 247, 248, 249, 250, 253, 254, 255, 256, 257, 258, 259, 262, 263, 264, 265, 266, 267, 268, 271, 272, 273, 275, 276, 277
src/rpcvalue.rs 0 -17 +2.48%
TOTAL +197 +152 -2.29%

Overall coverage

Click to expand
Filename Stmts Miss Cover Missing
src/jaq.rs 180 173 3.89% 11-229, 237, 241-277
src/cpon.rs 530 85 83.96% 35-37, 41, 45-47, 55, 60, 65-67, 80, 84-86, 100, 107-114, 133-154, 166-205, 308-309, 337-338, 344, 366, 379-383, 413, 429, 455-460, 497, 499-503, 518, 645
src/reader.rs 64 5 92.19% 21-23, 66, 84
src/writer.rs 18 0 100.00%
src/rpcvalue.rs 686 161 76.53% 70, 72-76, 78, 80-81, 84-99, 126-128, 174-176, 216-218, 257-262, 413-425, 433, 450, 457-462, 480, 487-512, 520, 532, 559, 576, 593, 603, 613, 623, 643, 653, 663, 673, 683, 697-726, 926-943, 982-984, 988, 998, 1004-1013, 1017, 1020-1026, 1030, 1033-1038, 1042, 1054, 1066, 1072, 1078, 1081-1096, 1144-1152
src/textrdwr.rs 237 29 87.76% 47-72, 132, 135, 145, 148, 160, 168-170, 213, 229, 244, 254, 270, 312
src/util.rs 84 43 48.81% 24, 31-77
src/serde.rs 52 27 48.08% 21-64, 74-82
src/json.rs 411 22 94.65% 221, 257, 265, 278, 319-333, 349, 394-396, 408, 518
src/decimal.rs 215 2 99.07% 131-134
src/chainpack.rs 635 14 97.80% 87, 120, 270-282, 287
src/metamap.rs 106 34 67.92% 44-51, 67-72, 86-93, 99, 126-143
src/datetime.rs 167 49 70.66% 91-95, 103, 109-114, 118-120, 141, 154, 165-166, 181, 185-232
src/lib.rs 9 0 100.00%
src/serde/de.rs 389 112 71.21% 30, 36-37, 50, 75, 86-91, 104, 106-108, 119-124, 140-142, 146-151, 160, 177, 181-209, 252-254, 279-300, 313, 343, 348-354, 373-403, 416-418, 427-433, 456-458, 489-491
src/serde/ser.rs 580 330 43.10% 13-15, 50-52, 66-80, 86-88, 98-115, 138, 142-156, 162-173, 227-378, 387-438, 444-583, 608-633, 676-679, 784
src/bin/cp2cp.rs 118 33 72.03% 65, 106-107, 127-133, 146, 150-151, 160-162, 171-173, 182-184, 188, 200-209, 213-214
libshvproto-macros/src/lib.rs 291 30 89.69% 13, 24, 27, 41, 111, 115-118, 135, 239, 259, 262-268, 277-281, 295, 303-306, 399, 435, 494
TOTAL 4772 1149 75.92%

HTML reports

You can use GitHub CLI to download HTML coverage reports and open them automatically using this command:

(cd "$(mktemp -d)" && gh run -R silicon-heaven/libshvproto-rs download -n libshvproto-cov-html-435d136a68814851985b443793a8a12a04ff155d && ls -1 | xargs -n1 xdg-open)

You can download the HTML reports manually here.

Comment thread src/bin/cp2cp.rs Outdated
@syyyr syyyr marked this pull request as draft December 24, 2025 09:41
@syyyr syyyr marked this pull request as ready for review December 24, 2025 09:56
@syyyr

syyyr commented Dec 26, 2025

Copy link
Copy Markdown
Contributor Author

Needs #92

@syyyr syyyr force-pushed the cq branch 4 times, most recently from ba86e31 to 4775f38 Compare December 31, 2025 15:06
@syyyr syyyr force-pushed the cq branch 2 times, most recently from d149772 to 8f416d6 Compare January 5, 2026 11:29

@fvacek fvacek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about to wrap jq support to feature? I like to have option to switch this dependency off in case of possible future releases build issues.

@syyyr syyyr force-pushed the cq branch 3 times, most recently from c44b340 to e6af58b Compare January 6, 2026 12:30
@syyyr syyyr force-pushed the cq branch 2 times, most recently from 65166c7 to 1bbf604 Compare January 6, 2026 12:34
@syyyr syyyr merged commit b097388 into master Jan 6, 2026
9 checks passed
@syyyr syyyr deleted the cq branch January 6, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants