Skip to content

Add a field for original timestamp to JournalEntry#111

Merged
j4r0u53k merged 1 commit into
masterfrom
journal-entry-epoch-msec-orig
Jun 15, 2026
Merged

Add a field for original timestamp to JournalEntry#111
j4r0u53k merged 1 commit into
masterfrom
journal-entry-epoch-msec-orig

Conversation

@j4r0u53k

Copy link
Copy Markdown
Contributor

The field can be used to track original timestamps of non-monotonic journal entries in getLog result.

When a getLog implementation encounters a non-monotonic timestamp, it change its timestamp to the last monotonic one to keep the monotonicity invariant in the result, but it saves the original timestamp in a new field.

The field can be used to track original timestamps of non-monotonic
journal entries in getLog result.

When a getLog implementation encounters a non-monotonic timestamp,
it change its timestamp to the last monotonic one to keep the
monotonicity invariant in the result, but it saves the original
timestamp in a new field.
@j4r0u53k j4r0u53k requested a review from syyyr June 15, 2026 15:33
@github-actions

Copy link
Copy Markdown

Code coverage report for c18ccc0

Coverage difference

❌ Code coverage worsened.

Filename Stmts Miss Cover Missing
src/journalrw.rs +24 +2 +0.22% 414, 417
TOTAL +24 +2 +0.12%

Overall coverage

Click to expand
Filename Stmts Miss Cover Missing
src/websocketrw.rs 67 24 64.18% 28-42, 55-64, 105-115, 128, 161-163
src/rpcdiscovery.rs 262 48 81.68% 45-62, 72, 103-105, 166, 168-169, 179, 183-186, 211, 213-214, 221-232, 245-262, 272, 278, 283
src/serialrw.rs 203 27 86.70% 44-47, 124-127, 131-138, 156-157, 203-205, 243-246, 261, 285-287
src/streamrw.rs 110 19 82.73% 32-35, 70-74, 80, 113-115, 135-145
src/canrw.rs 569 168 70.47% 34-58, 101-158, 176-203, 219-306, 331, 359-366, 395-398, 405-406, 416-418, 430-441, 476, 528-548
src/framerw.rs 141 37 73.76% 23, 33, 40-56, 81-87, 112-116, 123, 134, 150, 157-179, 201-203, 233
src/util.rs 289 52 82.01% 12-22, 31, 86-113, 150, 153, 184-194, 235-237
src/journalrw.rs 750 112 85.07% 79, 103, 135-140, 175, 309, 314, 320, 322, 337, 345-347, 363, 370, 380, 395, 403-406, 414, 417, 441-449, 462, 493-495, 509-546, 568-573, 577, 580, 594, 597-601, 606, 610-611, 616-617, 621-622, 626-627, 648-650, 662, 670-671, 693-719, 729-730, 734-735, 739-740, 744-745, 749-750, 754-755, 759-760, 764-765, 775-776, 780, 785-786, 988
src/client.rs 182 165 9.34% 24-271
src/typeinfo.rs 846 299 64.66% 72-74, 103-105, 113, 120-121, 134, 138, 146, 159-244, 264, 272, 287-289, 293-295, 320-335, 350-351, 368-369, 380-385, 391, 399, 433-434, 455-461, 506-519, 584-603, 628-630, 657-668, 694-695, 706-735, 765-767, 788-790, 804-829, 837, 932-934, 941, 951, 961-963, 971-977, 997-1040, 1061-1069, 1081-1090, 1102, 1125-1127, 1144, 1181, 1184, 1189-1190, 1227-1228, 1231-1232, 1239, 1259-1261, 1265-1269, 1273-1275
src/rpcmessage.rs 462 202 56.28% 56, 69, 84-95, 107, 112-113, 118-123, 154-158, 162-165, 168-177, 181-186, 190, 196-198, 202, 227-228, 235, 239, 245-257, 292-297, 302-304, 308-310, 320-325, 339-344, 354, 380-385, 433-476, 489, 504-523, 541-556, 566-638
src/datachange.rs 113 6 94.69% 100-104, 109
src/metamethod.rs 152 100 34.21% 26-34, 49, 51, 59-61, 88-91, 97, 99-105, 110-112, 143, 155-256, 288-290
src/rpcframe.rs 127 37 70.87% 25-30, 63, 72, 75, 78, 88-92, 120, 133-136, 152-183
src/rpc.rs 208 60 71.15% 33-35, 39-76, 92-94, 118-124, 138, 152, 172-188, 195, 203-213, 225-227
TOTAL 4481 1356 69.74%

HTML reports

@j4r0u53k j4r0u53k merged commit 74e57b1 into master Jun 15, 2026
11 checks passed
@j4r0u53k j4r0u53k deleted the journal-entry-epoch-msec-orig branch June 15, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants