Skip to content

Fix quant cache for comfy node #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

Conversation

lixiang007666
Copy link
Contributor

@lixiang007666 lixiang007666 commented May 8, 2025

Summary by CodeRabbit

  • New Features
    • Improved model loading to allow specifying a checkpoint name during speedup operations. This provides more flexibility when selecting and accelerating models.

@lixiang007666 lixiang007666 requested a review from ccssu May 8, 2025 07:46
Copy link
Contributor

coderabbitai bot commented May 8, 2025

Walkthrough

The SpeedupMixin.speedup method was updated to accept an optional ckpt_name parameter, which is now forwarded to the booster function. The OneDiffCheckpointLoaderSimple.onediff_load_checkpoint method was also updated to pass ckpt_name when invoking speedup. No other logic or control flow was changed.

Changes

File(s) Change Summary
onediff_comfy_nodes/_nodes.py Updated SpeedupMixin.speedup to accept and pass ckpt_name; updated OneDiffCheckpointLoaderSimple.onediff_load_checkpoint to pass ckpt_name to speedup.

Poem

A patch for the speedy, a hop for the name,
Now ckpt_name travels through the code’s gentle frame.
From loader to booster, the parameter flows,
Like a rabbit with secrets that only it knows.
🐇✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc2cd27 and 92326b6.

📒 Files selected for processing (1)
  • onediff_comfy_nodes/_nodes.py (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: diffusers_examples onediff:torch2.3-cuda11.8
🔇 Additional comments (2)
onediff_comfy_nodes/_nodes.py (2)

46-81: Good addition for checkpoint-based caching!

The addition of the ckpt_name parameter to the speedup method and passing it to the booster function is a good fix for the quantization cache issue. By using the checkpoint name as an identifier rather than just a temporary UUID, this enables more persistent caching based on the actual model being loaded. This should improve performance when the same checkpoint is loaded multiple times across different sessions.


238-252: Successfully propagating checkpoint name to the speedup function

This change properly forwards the checkpoint name from the loader to the speedup method, completing the fix for the quantization cache. Now the booster can use the checkpoint name for caching purposes rather than relying solely on temporary UUIDs.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@strint strint merged commit 98898c4 into main May 8, 2025
4 of 6 checks passed
@strint strint deleted the Fix_quant_cache_for_comfy_node branch May 8, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants