+semver:minor Added KeysExtensions class with the IsNavigationKey ext… #1437
+121
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ension method. Fixed a subtle bug in IbusKeyboardSwitchingAdaptor when determining whether IBus would have handled a key event while a pre-edit is active. The code now accounts for the possibility of modifier keys (particularly Ctrl), which IBus would presumably have handled when in combination with navigation keys, Backspace, and Delete.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // If IBus handled the key we don't want the control to get it. However, | ||
| // we can't do this in PreviewKeyDown, so we temporarily subscribe to | ||
| // KeyDown and suppress the key event there. | ||
| control.KeyDown += HandleKeyDownAfterIbusHandledKey; |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
To fix the issue, we need to ensure that control is not null before it is dereferenced on line 313. This can be achieved by adding a null check for control after it is assigned on line 286. If control is null, the method should return early, as further operations depend on control being valid.
This fix ensures that the method behaves safely even if sender is not of type Control, preventing a potential NullReferenceException.
Suggested changeset
1
SIL.Windows.Forms.Keyboarding/Linux/IbusKeyboardSwitchingAdaptor.cs
| @@ -286,2 +286,4 @@ | ||
| var control = sender as Control; | ||
| if (control == null) | ||
| return; | ||
| var eventHandler = GetEventHandlerForControl(control); |
Copilot is powered by AI and may make mistakes. Always verify output.
ermshiperete
approved these changes
May 23, 2025
|
|
||
| ### Fixed | ||
|
|
||
| - [SIL.Windows.Kwyboarding] Fixed a subtle bug in IbusKeyboardSwitchingAdaptor when determining whether IBus would have handled a key event while a pre-edit is active. The code now accounts for the possibility of modifier keys (particularly Ctrl), which IBus would presumably have handled when in combination with navigation keys, Backspace, and Delete. |
There was a problem hiding this comment.
Suggested change
| - [SIL.Windows.Kwyboarding] Fixed a subtle bug in IbusKeyboardSwitchingAdaptor when determining whether IBus would have handled a key event while a pre-edit is active. The code now accounts for the possibility of modifier keys (particularly Ctrl), which IBus would presumably have handled when in combination with navigation keys, Backspace, and Delete. | |
| - [SIL.Windows.Keyboarding] Fixed a subtle bug in IbusKeyboardSwitchingAdaptor when determining whether IBus would have handled a key event while a pre-edit is active. The code now accounts for the possibility of modifier keys (particularly Ctrl), which IBus would presumably have handled when in combination with navigation keys, Backspace, and Delete. |
Comment on lines
+342
to
+344
| /// REVIEW: During pre-edit, I assume that IBus handles both basic and modified navigation | ||
| /// keys like Ctrl+Left. ChatGPT says this is true, but I have not been able to verify this | ||
| /// since I don't know how to set up a Linux/IBus environment where I could test this. |
There was a problem hiding this comment.
To test this on Linux:
- install Ubuntu 24.04 in a VM
- install an IME that uses pre-edit: in a terminal run
sudo apt update && sudo apt install ibus-pinyin - open Keyboard settings, click "+ Add Input Source", search for Pinyin by clicking on the three dots below English. If you type the search term "pinyin" you'll get "Other". Clicking that shows "Chinese (Pinyin)" which you then can add.
- close the settings
- in the terminal run
ibus restart(or reboot) - the language/keyboard picker in the top bar should now show "Chinese (Pinyin)".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ension method.
Fixed a subtle bug in IbusKeyboardSwitchingAdaptor when determining whether IBus would have handled a key event while a pre-edit is active. The code now accounts for the possibility of modifier keys (particularly Ctrl), which IBus would presumably have handled when in combination with navigation keys, Backspace, and Delete.
This change is