-
Notifications
You must be signed in to change notification settings - Fork 5
Company Checker #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@mativs is attempting to deploy a commit to the conanbatt's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Está bueno. Ahora mismo es directo lo que devuelve la IA a lo que se muestra (se muestra tal cual lo que responde, en un card con puro texto). Dejo algunas sugerencias:
|
@nicopujia nueva propuesta en base a las observaciones!! 😄 |
a181f96 to
2954b60
Compare
|
@nicopujia podes revisar este PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Luego de la review 3 meses tarde mi opinión es que hay que dejar este proyecto porque las herramientas existentes son por lejos mucho mejores y hacer un buen Company Checker llevaría demasiado trabajo.
| return ( | ||
| <> | ||
| <Home /> | ||
| <GoogleAnalytics gaId="G-QFVTDBRTP4" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No hace falta repetirlo
| export const metadata: Metadata = { | ||
| title: "Resume Checker", | ||
| description: | ||
| "Upload your CV and get instant feedback to improve your job application.", | ||
| openGraph: { | ||
| title: "Resume Checker • Open Silver", | ||
| description: | ||
| "Get instant feedback on your resume to improve your job application", | ||
| type: "website", | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arreglar eso
| @@ -0,0 +1,17 @@ | |||
| import { Lato } from "next/font/google"; | |||
| import { type ReactNode } from "react"; | |||
| const lato = Lato({ subsets: ["latin"], weight: "400" }); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sacar esa fuente, que se use siempre la del layout.tsx principal
| const cardColors = [ | ||
| "bg-gradient-to-br from-blue-50/30 to-blue-100/20 dark:from-blue-950/20 dark:to-blue-900/10 border-blue-100/50 dark:border-blue-800/30", | ||
| "bg-gradient-to-br from-purple-50/30 to-purple-100/20 dark:from-purple-950/20 dark:to-purple-900/10 border-purple-100/50 dark:border-purple-800/30", | ||
| "bg-gradient-to-br from-green-50/30 to-green-100/20 dark:from-green-950/20 dark:to-green-900/10 border-green-100/50 dark:border-green-800/30", | ||
| "bg-gradient-to-br from-amber-50/30 to-amber-100/20 dark:from-amber-950/20 dark:to-amber-900/10 border-amber-100/50 dark:border-amber-800/30", | ||
| "bg-gradient-to-br from-rose-50/30 to-rose-100/20 dark:from-rose-950/20 dark:to-rose-900/10 border-rose-100/50 dark:border-rose-800/30", | ||
| "bg-gradient-to-br from-cyan-50/30 to-cyan-100/20 dark:from-cyan-950/20 dark:to-cyan-900/10 border-cyan-100/50 dark:border-cyan-800/30", | ||
| ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Con incluir colores me refería p. ej. a iconos o títulos con el naranjita de Silver. Estos colores son re random, no les veo el sentido ni la utilidad.
| import ReactMarkdown from "react-markdown"; | ||
|
|
||
| function removeTripleBackticks(text: string): string { | ||
| // Trim leading/trailing whitespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: demasiados comentarios
| <Spacer size="lg" /> | ||
| <div className="text-center"> | ||
| <p className="text-lg mb-4"> | ||
| Para una búsqueda más profunda probá directamente en{" "} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review de producto:
Si para una búsqueda más profunda deberíamos ir con el prompt a ChatGPT, entonces por qué usar el Company Checker en primer lugar? Encima me tira un montón de texto, complicado de leer en mi opinión, y a eso sumale su dudosa veracidad ya que ni busca en internet.
| @@ -0,0 +1,13 @@ | |||
| "use client"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Al igual mencioné en el otro PR:
Fijate que el pages router quedó de antes, pero mi idea es usar al app router, así no tenemos que duplicar cada página en ambos. Así que usá el app router directo.
1f4ab23 to
8b633c4
Compare

Descripción de los cambios
Nueva funcionalidad: Company Checker
Se ha implementado una nueva herramienta llamada "Company Checker" que permite a los usuarios investigar empresas de su interés para prepararse para entrevistas laborales.
Características principales:
Componentes implementados:
Mejoras técnicas:
Archivos modificados:
/company-checkeral menú principalConfiguración del entorno:
Para que la funcionalidad funcione correctamente, es necesario configurar la siguiente variable de entorno:
.env.localen la raíz del proyectotu_api_key_aquícon tu API key de Google Generative AILa herramienta está lista para su uso y proporciona una forma eficiente de investigar empresas antes de las entrevistas laborales.