Adding support for hosting with URL prefix #1357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p on sub-path possible
…er rebasing from upstream
flowkclav
force-pushed
the
163-support-subpath
branch
from
bed4fb6 to
0c972e6
Compare
|
Thanks for this. I need the time to properly tests this. I anticipate a lot of edge cases and places where being hosted at the root is implicitly assumed. |
|
Absolutely! I am fairly new to silverbullet so it is very possible that I missed something. As if to illustrate my point, I just realised I never tested in offline mode. I just did and sure enough, the service_worker.ts will need tweaking. And unlike the rest of the client code, it doesn't have access to document.baseURI to derive the prefix. I'll try to take a closer if I have some more time. |
* Add more tests for week calculation * Fix week calculation * Add more tests
* Implement Lua built-in function os.difftime * Test os.difftime --------- Co-authored-by: Zef Hemel <[email protected]>
* Generate version from git describe at build time * Add 2.0-beta prefix * Use Deno.Command instead of Deno.run
Configurable with queryCollation, default value maintains old behaviour. Added tests, schema, example settings, and documentation to query page. Close: silverbulletmd#614 Close: silverbulletmd#1316
…ulletmd#1386) * Add global Lua function 'some' Moved documentation for 'each' function to non-standard section. * Revert "Add optional argument to template.each for empty collection output (silverbulletmd#1359)" This reverts commit b73dade. * Reimplement silverbulletmd#1359 using 'some' function
…d#1397) The documentation, example, and other function names use `event.listEvents`, but `event.list` is being registered with the client.
Also add a 10px margin below the header to maintain consistent spacing around the widget contents.
…d#1392) * Add optional priority attribute to PageCreatingContent * Minor simplification * Fix comments * Revert changes * Add pageEventHandlers
Now storing config in localStorage.
|
Thanks a lot for this effort, a lot of people have asked for it! I'm sure there may be subtle issues, but based on some testing this seems to work great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163. Adding support for hosting with URL prefix to make reverse-proxy setup on sub-path possible.
Starting silverbullet server specifying a "prefix" (or "context root") in environment variable
SB_URL_PREFIXwill cause the application to be hosted on the specified prefix. This allows sub-path configuration when setting up reverse proxies (e.g.https://myserver/sb/->http://localhost:3000/sb/)Summary of changes:
baseelement ofindex.htmlandauth.html/myresource) to page-relative URLs (e.g.myresource)document.baseURIinstead oflocation.origin|hostwhen constructing URLsNOTES:
JSON utils => ./plug-api/lib/json.test.ts:4:6fails withActual 2023-05-02 / Expected 2023-05-03. Probably a timezone thing). I left it alone.