ShopCurrency: Add configurable decimals and NumericField scaffolding#859
Merged
ShopCurrency: Add configurable decimals and NumericField scaffolding#859
Conversation
…pCurrency Agent-Logs-Url: https://github.com/silvershop/silvershop-core/sessions/edf8a9a8-d485-48d4-a70e-98e1b0426e8e Co-authored-by: wilr <[email protected]>
Copilot
AI
changed the title
[WIP] Add scaffold numeric fields for price in ShopCurrency
ShopCurrency: Add configurable decimals and NumericField scaffolding
May 1, 2026
Contributor
|
@copilot Fix the lint issues and rebase |
Co-authored-by: wilr <[email protected]>
Contributor
Author
Fixed in commit |
Copilot stopped work on behalf of
wilr due to an error
May 2, 2026 01:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decimalsconfig toShopCurrency(default:2)Nice()to use thedecimalsconfig instead of hardcoded2scaffoldFormField()method returningNumericFieldwithsetScale()from configdecimalsconfig usage inNice()andscaffoldFormField()