Merged
Conversation
23 tasks
emteknetnz
force-pushed
the
main
branch
5 times, most recently
from
0a6a4af to
f8546aa
Compare
GuySartorelli
requested changes
Jun 9, 2022
Member
GuySartorelli
left a comment
GuySartorelli
left a comment
There was a problem hiding this comment.
It's probably obvious and I have just completely missed it - is there configuration added somewhere to this action which makes it so that a single step failing doesn't cause the other steps to fail?
Or is that just the default? I think now that I'm writing it that this is the default but can you please confirm?
emteknetnz
force-pushed
the
main
branch
3 times, most recently
from
a00bb84 to
9fcc2a9
Compare
GuySartorelli
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/github-actions-ci-cd#36