FIX: ensure children keep the same visibility when writing folder#682
Open
sunnysideup wants to merge 1 commit intosilverstripe:2from
Open
FIX: ensure children keep the same visibility when writing folder#682sunnysideup wants to merge 1 commit intosilverstripe:2from
sunnysideup wants to merge 1 commit intosilverstripe:2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When you write a folder (in my case I was setting up default folders using the requireDefaultRecords method), it also write all its children.
For some reason, when you extend the File (e.g. Document extends File), this start behaving differently. With this extension, if a file is in a folder, and you write the folder, the file becomes "protected" (or at least modified on draft).
The code is here:
https://github.com/silverstripe/silverstripe-assets/blob/2/src/Folder.php#L296-L298
This is called from
onAfterWriteand also fromonAfterSkippedWrite(akin to an onBeforeWrite).Manual testing steps
class Document extends FileIssues
Here are a couple of issues that may relate:
Pull request checklist