FIX Make PageinatedList::count() give the number of items in the current page#11634
Merged
emteknetnz merged 1 commit intosilverstripe:6.0from Mar 13, 2025
Merged
Conversation
2 tasks
GuySartorelli
commented
Mar 11, 2025
Member
Author
|
CI failures are also happening on the |
emteknetnz
requested changes
Mar 12, 2025
GuySartorelli
force-pushed
the
pulls/6.0/paginated-list-count
branch
from
29f9568 to
e7d7dd7
Compare
emteknetnz
reviewed
Mar 12, 2025
Member
emteknetnz
left a comment
emteknetnz
left a comment
There was a problem hiding this comment.
Have tested locally, works well. Will approve + merge once CMS 5 PRs have been merged + merged up
GuySartorelli
force-pushed
the
pulls/6.0/paginated-list-count
branch
2 times, most recently
from
d130aea to
4ae68fb
Compare
GuySartorelli
force-pushed
the
pulls/6.0/paginated-list-count
branch
from
4ae68fb to
8b2b38d
Compare
Member
|
Failing build, hasn't been merged-up/rebased? |
Member
Author
|
See #11634 (comment) above. |
emteknetnz
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue