FIX Remove non-readonly components from sudo mode gridfield#11639
Merged
GuySartorelli merged 1 commit intosilverstripe:6.0from Mar 20, 2025
Merged
Conversation
GuySartorelli
approved these changes
Mar 20, 2025
Member
GuySartorelli
left a comment
GuySartorelli
left a comment
There was a problem hiding this comment.
LGTM - I've added a note to myself that we may want to call this out clearly in the changelog as a fixed bug but that will be done separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#378
Kitchen sink run to validate it fixes the issue in admin - https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/13959002995
6.0 fixed up some referencing stuff in GridField::performReadonlyTransformation() - fd5c465#diff-c5907f790efc160f18abbccf8d6d3de8e13eff90e5b3a6119e1447da06f70c40R278-L300
This code changes accounts for that