FIX Use search context when no database field for label#11655
Merged
GuySartorelli merged 1 commit intosilverstripe:5.3from Mar 30, 2025
Merged
FIX Use search context when no database field for label#11655GuySartorelli merged 1 commit intosilverstripe:5.3from
GuySartorelli merged 1 commit intosilverstripe:5.3from
Conversation
2 tasks
emteknetnz
force-pushed
the
pulls/5.3/search-fallback
branch
from
df86694 to
785855a
Compare
GuySartorelli
requested changes
Mar 27, 2025
Member
There was a problem hiding this comment.
The PHPDoc for getUseSearchContext() and setUseSearchContext() should be updated to reflect that the search context will be used if the label field isn't a database field even if useSearchContext is false.
The fact that label field is used for searching by default should maybe also be added to setLabelField() and getLabelField().
Alternatively this context could maybe be added to the PHPDoc for the class itself.
emteknetnz
force-pushed
the
pulls/5.3/search-fallback
branch
from
785855a to
213954d
Compare
Member
Author
|
Have added docblock comments |
GuySartorelli
requested changes
Mar 27, 2025
emteknetnz
force-pushed
the
pulls/5.3/search-fallback
branch
from
213954d to
ef6c4cf
Compare
Contributor
|
:-) this is looking great thanks for the follow up! |
GuySartorelli
approved these changes
Mar 30, 2025
Member
GuySartorelli
left a comment
GuySartorelli
left a comment
There was a problem hiding this comment.
LGTM, works as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #11647