Skip to content

MNT Set title_format for unit test#11675

Merged
GuySartorelli merged 1 commit intosilverstripe:5.3from
creative-commoners:pulls/5.3/title-format
Apr 8, 2025
Merged

MNT Set title_format for unit test#11675
GuySartorelli merged 1 commit intosilverstripe:5.3from
creative-commoners:pulls/5.3/title-format

Conversation

@emteknetnz
Copy link
Copy Markdown
Member

@emteknetnz emteknetnz commented Apr 8, 2025

@emteknetnz emteknetnz marked this pull request as ready for review April 8, 2025 05:52
Copy link
Copy Markdown
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For context, CWP is changing this config in https://github.com/silverstripe/cwp/blob/3/_config/config.yml which is causing this test to fail in SINK but not in framework or other recipe test suites.

This change just puts the configuration in a predictable state, which is what you want for a test.

@GuySartorelli GuySartorelli merged commit 8ed8005 into silverstripe:5.3 Apr 8, 2025
19 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.3/title-format branch April 8, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants