FIX Fix condition checking if a member exists#11794
Merged
GuySartorelli merged 1 commit intosilverstripe:6.0from Jul 20, 2025
Merged
FIX Fix condition checking if a member exists#11794GuySartorelli merged 1 commit intosilverstripe:6.0from
GuySartorelli merged 1 commit intosilverstripe:6.0from
Conversation
GuySartorelli
commented
Jul 20, 2025
| $hash = $session->get('AutoLoginHash'); | ||
| if ($hash) { | ||
| if (!Member::get()->filter(['AutoLoginHash' => $hash])) { | ||
| if (!Member::get()->filter(['AutoLoginHash' => $hash])->exists()) { |
Member
Author
There was a problem hiding this comment.
I could have changed filter() to find() but using exists() is more efficient both in the db itself (uses a SELECT 1 CASE EXISTS (SELECT <where etc>) ELSE 0 query) and in PHP-land since it's a boolean and therefore we don't have to hydrate a whole DataObject record just to throw it away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
ChangePasswordHandler::createChangePasswordResponse()#11793