ENH Reduce count queries for scaffolding SearchableDropdownField#11823
Merged
emteknetnz merged 1 commit intosilverstripe:6from Aug 12, 2025
Merged
Conversation
GuySartorelli
commented
Aug 12, 2025
Comment on lines
+1494
to
+1498
| $overThreshold = $threshold === 0 || $list->setUseCache(true)->count() > $threshold; | ||
| $field->setIsLazyLoaded($overThreshold); | ||
| if ($threshold > 0) { | ||
| $field->setLazyLoadLimit($threshold); | ||
| } |
Member
Author
There was a problem hiding this comment.
The checks against $threshold being 0 mirror what was done in #11646 for DataObject::scaffoldFormFieldForHasOne()
2 tasks
emteknetnz
approved these changes
Aug 12, 2025
This was referenced Aug 18, 2025
Reduce count queries when scaffolding
SearchableDropdownField
silverstripe/silverstripe-taxonomy#134
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By caching the count query we can avoid sending repeated count queries for scaffolding multiple
SearchableDropdownFieldfor the same class.Issue