Skip to content

ENH Make it clear deprecations are removed in future major #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emteknetnz merged 1 commit into from
Apr 30, 2025
Merged

ENH Make it clear deprecations are removed in future major #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Tasks/GorriecoeMigrationTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
use SilverStripe\ORM\DB;

/**
* @deprecated 4.0.0 Will be removed without equivalent functionality.
* @deprecated 4.0.0 Will be removed without equivalent functionality in a future major release.
*/
class GorriecoeMigrationTask extends BuildTask
{
Expand Down
2 changes: 1 addition & 1 deletion src/Tasks/LinkFieldMigrationTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
use SilverStripe\Versioned\Versioned;

/**
* @deprecated 4.0.0 Will be removed without equivalent functionality.
* @deprecated 4.0.0 Will be removed without equivalent functionality in a future major release.
*/
class LinkFieldMigrationTask extends BuildTask
{
Expand Down
2 changes: 1 addition & 1 deletion src/Tasks/LinkableMigrationTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
use SilverStripe\ORM\DB;

/**
* @deprecated 4.0.0 Will be removed without equivalent functionality.
* @deprecated 4.0.0 Will be removed without equivalent functionality in a future major release.
*/
class LinkableMigrationTask extends BuildTask
{
Expand Down
6 changes: 3 additions & 3 deletions src/Tasks/MigrationTaskTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,17 @@ public function __construct()
{
// Use withSuppressedNotice() because otherwise even viewing the dev/tasks list will trigger this warning.
Deprecation::withSuppressedNotice(
fn () => Deprecation::notice('4.0.0', 'Will be removed without equivalent functionality.', Deprecation::SCOPE_CLASS)
fn () => Deprecation::notice('4.0.0', 'Will be removed without equivalent functionality in a future major release.', Deprecation::SCOPE_CLASS)
);
parent::__construct();
}

/**
* @deprecated 4.2.0 Will be replaced with execute()
* @deprecated 4.2.0 Will be replaced with execute() in a future major release
*/
public function run($request): void
{
Deprecation::noticeWithNoReplacment('4.2.0', 'Will be replaced with execute()');
Deprecation::noticeWithNoReplacment('4.2.0', 'Will be replaced with execute() in a future major release');
$db = DB::get_conn();

// If we don't need to migrate, exit early.
Expand Down
2 changes: 1 addition & 1 deletion src/Tasks/ModuleMigrationTaskTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
use SilverStripe\Versioned\Versioned;

/**
* @deprecated 4.0.0 Will be removed without equivalent functionality.
* @deprecated 4.0.0 Will be removed without equivalent functionality in a future major release.
*/
trait ModuleMigrationTaskTrait
{
Expand Down