FIX Ensure change tracker not triggered by presence of MultiLinkField#383
Merged
GuySartorelli merged 1 commit intosilverstripe:4.2from May 21, 2025
Conversation
2 tasks
emteknetnz
force-pushed
the
pulls/4.2/multi-change-tracker
branch
from
129d928 to
75af125
Compare
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/4.2/multi-change-tracker
branch
from
75af125 to
ae47ec6
Compare
emteknetnz
changed the title
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/4.2/multi-change-tracker
branch
from
ae47ec6 to
c8adef9
Compare
emteknetnz
force-pushed
the
pulls/4.2/multi-change-tracker
branch
from
c8adef9 to
9f5f73e
Compare
Member
There was a problem hiding this comment.
I can't reproduce the bug without this PR which makes it impossible to test if this is actually fixing anything. I followed the reproduction steps in the issue.
Screencast.from.21-05-25.11.02.19.webm
Can you please give me some steps or a recording that shows how I can reproduce the original bug?
Member
Author
|
Need to focus on a non-react field I think I used the link field test page in framewortest and then clicked on the page title field |
Member
|
Oh, I see. The issue steps say "add a MultiLinkField to any form (for example an Elemental block)" - but apparently adding one in an elemental block explicitly does not exhibit this problem. I'll update the steps in the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #379