Skip to content

FIX Missing extension key.#391

Merged
GuySartorelli merged 4 commits into4.2from
bugfix/missing-extension-key
Jun 23, 2025
Merged

FIX Missing extension key.#391
GuySartorelli merged 4 commits into4.2from
bugfix/missing-extension-key

Conversation

@mfendeksilverstripe
Copy link
Copy Markdown
Collaborator

FIX Missing extension key.

Fix for #390

@GuySartorelli
Copy link
Copy Markdown
Member

Please also update the documentation in https://github.com/silverstripe/silverstripe-linkfield/blob/5/docs/en/01_basic_usage.md#unversioned-links to suggest using YAML instead of suggesting runtime code.

@mfendeksilverstripe
Copy link
Copy Markdown
Collaborator Author

I've updated the docs @GuySartorelli , please review.

Copy link
Copy Markdown
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick.
Please also check the failed doc linting CI job. I think it's probably complaining that you used yaml instead of yml for the code fence

Comment thread docs/en/01_basic_usage.md Outdated
mfendeksilverstripe and others added 2 commits June 23, 2025 15:07
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
Copy link
Copy Markdown
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 0bf27e3 into 4.2 Jun 23, 2025
17 checks passed
@GuySartorelli GuySartorelli deleted the bugfix/missing-extension-key branch June 23, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants