Skip to content

FIX Drop already-verified check from SessionStore #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cheddam wants to merge 1 commit into
base: 5.3
Choose a base branch
from
Open

FIX Drop already-verified check from SessionStore #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Store/SessionStore.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,6 @@ public function getMethod(): ?string
*/
public function setMethod(?string $method): StoreInterface
{
if (in_array($method, $this->getVerifiedMethods() ?? [])) {
throw new InvalidMethodException('You cannot verify with a method you have already verified');
}

$this->method = $method;

return $this;
Expand Down
9 changes: 0 additions & 9 deletions tests/php/Store/SessionStoreTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,6 @@ public function testAddState()
$this->assertSame(['foo' => 'baz', 'bar' => 'baz'], $store->getState());
}

public function testSetMethodWithVerifiedMethod()
{
$this->expectException(\SilverStripe\MFA\Exception\InvalidMethodException::class);
$this->expectExceptionMessage('You cannot verify with a method you have already verified');
$store = new SessionStore($this->createMock(Member::class));
$store->addVerifiedMethod('foobar');
$store->setMethod('foobar');
}

public function testSetMethod()
{
$store = new SessionStore($this->createMock(Member::class));
Expand Down