FIX Allow non-multi TagField to be cleared#338
Merged
GuySartorelli merged 1 commit intosilverstripe:3.4from Nov 26, 2025
Merged
FIX Allow non-multi TagField to be cleared#338GuySartorelli merged 1 commit intosilverstripe:3.4from
GuySartorelli merged 1 commit intosilverstripe:3.4from
Conversation
2 tasks
emteknetnz
force-pushed
the
pulls/3.4/clearble
branch
from
1f966cd to
d042eb9
Compare
emteknetnz
force-pushed
the
pulls/3.4/clearble
branch
from
d042eb9 to
ac2c2cf
Compare
GuySartorelli
approved these changes
Nov 26, 2025
Member
GuySartorelli
left a comment
GuySartorelli
left a comment
There was a problem hiding this comment.
LGTM, works as expected for TagField and StringTagField.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #335
I've done this as a bugfix, though it could be argued that it should be done as a minor release since there's a behavioural change
I've added props with a default value for TagField in case we want to add PHP API later on to to control this i.e. -
>setIsClearable(false)